1762043 - .startup-incomplete created at TB start and not removed

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Rachel Martin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Delete all .startup-incomplete from your file system. Start TB.
.startup-incomplete created. This should be deleted after successful startup:
https://searchfox.org/mozilla-central/rev/570f6e5c06b6c8140f53bf104d785a18165212ab/toolkit/components/extensions/test/mochitest/test_startup_canary.html#32

  // The ".startup-incomplete" file is created at the startup, and supposedly
  // cleared "soon" after startup (when the application knows that the startup
  // succeeded without crash). Bug 1624724 and bug 1728461 show that this has
  // not always been the case, so this regression test verifies that the file
  // is actually non-existent when this test start, see
  // https://bugzilla.mozilla.org/show_bug.cgi?id=1728461#c12

Apparently related to checking for crashes according to the comments here:
https://searchfox.org/mozilla-central/rev/570f6e5c06b6c8140f53bf104d785a18165212ab/toolkit/xre/nsAppRunner.cpp#4644

Comment 1

[Rachel Martin]

Alice, when you have a moment: Has this always been that way? Could you please check.

Comment 2

[Rachel Martin]

Looks like code equivalent to
https://searchfox.org/mozilla-central/search?q=TrackStartupCrashEnd&path=BrowserGlue.jsm&case=false&regexp=false
is missing in TB. Alice, sorry about the noise.

Comment 3

[Rachel Martin]

https://github.com/Betterbird/thunderbird-patches/blob/main/91/bugs/1762043-fix-startup-incomplete.patch

Comment 4

[:aceman]

I do not seem to get this file. Where can it be seen?

Comment 5

[:aceman]

OK, on Linux it is in the ~/.cache folder, not in the profile. It is removed after TB close, but not soon after startup.

Comment 6

[b2]

On Windows, the file is created in the profile folder and not removed at all. Patch based on:
https://searchfox.org/mozilla-central/rev/cdbf03e2dfa293023d477af83e124558437dcb43/browser/components/BrowserGlue.jsm#1994-1996
https://searchfox.org/mozilla-central/rev/cdbf03e2dfa293023d477af83e124558437dcb43/browser/components/BrowserGlue.jsm#2681-2691

Comment 7

[:aceman]

Attachment: 1762043-fix-startup-incomplete.patch based on comment 3

This works for me and removes the file after 30 seconds.

I had to update the patch as it seems MailGlue.jsm file has changed since the patch and it also referenced Betterbird specific code, thus the patch didn't apply.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9296112 [details] [diff] [review]
1762043-fix-startup-incomplete.patch based on comment 3

Review of attachment 9296112 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok apart from the below. r=mkmelin

::: mail/components/MailGlue.jsm
@@ +368,5 @@
> +        try {
> +          Services.startup.trackStartupCrashEnd();
> +        } catch (e) {
> +          Cu.reportError(
> +            "Could not end startup crash tracking in quit-application-granted: " + e

The try-catch seems unneeded. Firefox doesn't use any either

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/578348d9bc99
Add missing call to Services.startup.trackStartupCrashEnd(). r=mkmelin

Comment 10

[:aceman]

Ok, thanks.