1762088 - Implement parsing / serialization for container properties.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1762088 - Allow to derive Parse/ToCss/SpecifiedValueInfo on bitflags. r=#style,#layout-reviewers

We keep getting this pattern of properties that have a set of joint and
disjoint flags, and copy-pasting or writing the same parsing and
serialization code in slightly different ways.

container-type is one such type, and I think we should have a single way
of dealing with this, thus implement deriving for various traits for
bitflags, with an attribute that says which flags are single vs mixed.

See docs and properties I ported. The remaining ones I left TODOs with,
they are a bit trickier but can be ported with some care.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1762088 - Implement parsing / serialization for container{,-type,-name} CSS properties. r=#style,#layout-reviewers

Two noteworthy details that may seem random otherwise:

• Moving values around in nsStyleDisplay is needed so that the struct
  remains under the size limit that we have to avoid jumping allocator
  buckets.

• All the test expectation churn is because tests depend on
  container-type: size parsing to run, and now they run. Tests for
  the relevant bits I implemented are passing, with the only exception
  of some container-name-computed.html failures which are
  https://github.com/w3c/csswg-drafts/issues/7181. Safari agrees with
  us there.

Other notes when looking at the spec and seeing how it matches the
implementation:

• container syntax doesn't match spec, but matches tests and sanity:
  https://github.com/w3c/csswg-drafts/issues/7180

• container-type syntax doesn't quite match spec, but matches tests
  and I think it's a spec bug since the definition for the missing
  keyword is gone:
  https://github.com/w3c/csswg-drafts/issues/7179

Depends on D142418

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bb4d3114199
Allow to derive Parse/ToCss/SpecifiedValueInfo on bitflags. r=firefox-style-system-reviewers,layout-reviewers,boris

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdaf003569a7
Implement parsing / serialization for container{,-type,-name} CSS properties. r=firefox-style-system-reviewers,layout-reviewers,boris

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33463 for changes under testing/web-platform/tests

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9f904ba9e20
Remove assert that doesn't hold for text-decorations because of presentation hints.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/122d5fa4212e
Annotate a test that expectedly fails on android due to overlay scrollbars.

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1bb4d3114199
https://hg.mozilla.org/mozilla-central/rev/bdaf003569a7
https://hg.mozilla.org/mozilla-central/rev/d9f904ba9e20
https://hg.mozilla.org/mozilla-central/rev/122d5fa4212e

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Should we dupe bug 1744223, bug 1744224, and bug 1744228 over to this bug?

It looks like those were basically-fixed (at a CSS parsing/serialization level) by https://hg.mozilla.org/mozilla-central/rev/bdaf003569a7

(There's more to be done to support them in layout, but I'm not sure that these individual per-property bugs are the best spot to do that.)

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Yes