1762172 - Use new PDF iconography and description copy in MSIX packages

Status: NEW

(Firefox :: Installer, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=372810625&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/W78IZm6vS1ekB6pIvD7Bng/runs/0/artifacts/public/logs/live_backing.log

---

INFO -  Invoking: /builds/worker/fetches/msix-packaging/makemsix pack -d /builds/worker/.mozbuild/cache/mach-msix/msix-temp-nightly -p /builds/worker/workspace/outputs/target.installer.msix
[task 2022-03-30T11:47:15.604Z] 11:47:15     INFO -  Microsoft (R) makemsix version ..0
[task 2022-03-30T11:47:15.605Z] 11:47:15     INFO -  Copyright (C) 2017 Microsoft.  All rights reserved.
[task 2022-03-30T11:47:33.167Z] 11:47:33     INFO -  Error: 0x8bad1002
[task 2022-03-30T11:47:33.167Z] 11:47:33     INFO -  LOG:
[task 2022-03-30T11:47:33.167Z] 11:47:33     INFO -  Error in XML File [Line 138, Col 26] :: element 'FileTypeAssociation' is not allowed for content model '(AppExtensionHost|AppExtension|AppUriHandler|AppointmentDataProvider|EmailDataProvider|ContactDataProvider|AppExecutionAlias|AppService|Protocol|FileTypeAssociation)'
[task 2022-03-30T11:47:33.168Z] 11:47:33     INFO -  Call failed in /builds/worker/fetches/msix-packaging/src/msix/PAL/XML/xerces-c/XmlObject.cpp on line 68
[task 2022-03-30T11:47:33.168Z] 11:47:33     INFO -  Call failed in /builds/worker/fetches/msix-packaging/src/msix/msix.cpp on line 287
[task 2022-03-30T11:47:33.169Z] 11:47:33     INFO -  Error running mach:
[task 2022-03-30T11:47:33.169Z] 11:47:33     INFO -      ['--log-no-times', 'repackage', 'msix', '--channel', 'nightly', '--publisher', 'CN=Mozilla Corporation, OU=Firefox Engineering Operations, O=Mozilla Corporation, L=Mountain View, S=California, C=US', '--publisher-display-name', 'Mozilla Corporation', '--identity-name', 'MozillaFirefoxNightly', '--arch', 'x86', '--distribution-dir', '/builds/worker/fetches/distribution', '--verbose', '--makeappx', '/builds/worker/fetches/msix-packaging/makemsix', '--input', '/builds/worker/fetches/target.zip', '--output', '/builds/worker/workspace/outputs/target.installer.msix']
[task 2022-03-30T11:47:33.169Z] 11:47:33     INFO -  The error occurred in code that was called by the mach command. This is either
[task 2022-03-30T11:47:33.169Z] 11:47:33     INFO -  a bug in the called code itself or in the way that mach is calling it.
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -  You can invoke |./mach busted| to check if this issue is already on file. If it
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -  isn't, please use |./mach busted file repackage| to report it. If |./mach busted| is
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -  misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -  If filing a bug, please include the full output of mach, including this error
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -  message.
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -  The details of the failure are as follows:
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -  subprocess.CalledProcessError: Command '['/builds/worker/fetches/msix-packaging/makemsix', 'pack', '-d', '/builds/worker/.mozbuild/cache/mach-msix/msix-temp-nightly', '-p', '/builds/worker/workspace/outputs/target.installer.msix']' returned non-zero exit status 2.
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/mach_commands.py", line 2320, in repackage_msix
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -      output = repackage_msix(
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/repackaging/msix.py", line 691, in repackage_msix
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -      subprocess.check_call(args, universal_newlines=True)
[task 2022-03-30T11:47:33.170Z] 11:47:33     INFO -    File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
[task 2022-03-30T11:47:33.171Z] 11:47:33     INFO -      raise CalledProcessError(retcode, cmd)
[task 2022-03-30T11:47:33.226Z] 11:47:33    ERROR - Return code: 1
[task 2022-03-30T11:47:33.226Z] 11:47:33    ERROR - 1 not in success codes: [0]
[task 2022-03-30T11:47:33.226Z] 11:47:33  WARNING - setting return code to 2
[task 2022-03-30T11:47:33.226Z] 11:47:33    FATAL - Halting on failure while running ['/builds/worker/workspace/obj-build/_virtualenvs/common/bin/python', 'mach', '--log-no-times', 'repackage', 'msix', '--channel', 'nightly', '--publisher', 'CN=Mozilla Corporation, OU=Firefox Engineering Operations, O=Mozilla Corporation, L=Mountain View, S=California, C=US', '--publisher-display-name', 'Mozilla Corporation', '--identity-name', 'MozillaFirefoxNightly', '--arch', 'x86', '--distribution-dir', '/builds/worker/fetches/distribution', '--verbose', '--makeappx', '/builds/worker/fetches/msix-packaging/makemsix', '--input', '/builds/worker/fetches/target.zip', '--output', '/builds/worker/workspace/outputs/target.installer.msix']
[task 2022-03-30T11:47:33.226Z] 11:47:33    FATAL - Running post_fatal callback...
[task 2022-03-30T11:47:33.226Z] 11:47:33    FATAL - Exiting 2
[task 2022-03-30T11:47:33.226Z] 11:47:33     INFO - [mozharness: 2022-03-30 11:47:33.226733Z] Finished repackage step (failed)
[task 2022-03-30T11:47:33.293Z] cleanup

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1762100

Comment 2

[Andreea Pavel [:apavel]]

From element:

bhearsum (he/him): nalexander: It looks like we probably need another <uap:Extension section, if manifents like https://github.com/Tlaster/iHentai/blob/665086fb58b9aa0ed9bdd58270368d671ba5041b/src/iHentai/Package.appxmanifest#L52 are to be trusted.

Comment 3

[Intermittent Failures Robot]

14 failures in 3323 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 8
• try: 6

Platform and build breakdown:

• windows2012-64-shippable: 5
  • opt: 5
• windows2012-32-shippable: 5
  • opt: 5
• windows2012-32-devedition: 2
  • opt: 2
• windows2012-64-devedition: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1762172&startday=2022-03-28&endday=2022-04-03&tree=all

Comment 4

[[e-mail] (:bhearsum)]

Nick, I believe this is about the MSIX fallout from https://bugzilla.mozilla.org/show_bug.cgi?id=1762100. I'll assign to you for now but feel free to do as you wish (I didn't any other open bugs about this yet).

Comment 5

[Nick Alexander :nalexander [he/him]]

Mutating this to describe what it really is: update the MSIX packages to include the new PDF iconography and description text.

Interesting question: could we localize "Firefox PDF Document" in the MSIX packages? The packaging format supports doing so but it's not easy to arrange at this time.