1762100 - Make Windows show PDF files that will open with Firefox as "Firefox PDF Document"

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement)

Description

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

This ticket tracks changing the file type that gets displayed by Windows for PDF files that will open with Firefox from the current “Firefox HTML Document” to “Firefox PDF Document”.

Technically, I think this is straightforward: we duplicate FirefoxHTML-... to FirefoxPDF-..., bump the string, and use it for .pdf.

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1762100 - Part 1: Accommodate arbitrary ProgID roots in `set-default-browser-user-choice`. r?bhearsum

This anticipates separating the FirefoxPDF-... handler from the
FirefoxHTML-... handler.

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1762100 - Part 2: Add and use `FirefoxPDF-...` file association. r?bhearsum

This is simply the mechanics of s/FirefoxHTML-.../FirefoxPDF-.../. We
need this to alter the description ("Firefox PDF Document") and, in
subsequent commits, the display icon.

Generally I tried to keep alphabetical ordering: FirefoxHTML-...,
FirefoxPDF-..., FirefoxURL-...; and I generally tried to use the '-'
suffix to disambiguate the older FirefoxHTML from the newer suffixed
FirefoxHTML-... form.

Comment 3

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1762100 - Part 3: Expect and use `FirefoxPDF-...`. r?bhearsum

This does two things. First, it expects the special
FirefoxPDF-... ProgID to be available for UserChoice. We could manage
without it for a while, but eventually we expect set-to-default to
include PDFs. When that is the case, if it doesn't exist, something
has gone very wrong, and we'd like to find that out (via our existing
telemetry, which reports "missing" ProgIDs).

Second, it arranges to use the new FirefoxPDF-... ProgID when
setting-to-default.

Comment 4

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: Bug 1762100 - Part 4: Make MSIX have PDF-specific document description. r?bhearsum

In addition, this makes the other file associations have a non-default
description, like "Firefox HTML Document", which agrees (at least for
Release and Beta) with what the installer arranges. (The Windows
default description is otherwise "HTML Document", "PDF Document",
etc.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/202beaf50315
Part 1: Accommodate arbitrary ProgID roots in `set-default-browser-user-choice`. r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/5825ad8cb2be
Part 2: Add and use `FirefoxPDF-...` file association. r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/4f5619be4f9c
Part 3: Expect and use `FirefoxPDF-...`. r=bhearsum
https://hg.mozilla.org/integration/autoland/rev/cd0595cee3e0
Part 4: Make MSIX have PDF-specific document description. r=bhearsum

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/202beaf50315
https://hg.mozilla.org/mozilla-central/rev/5825ad8cb2be
https://hg.mozilla.org/mozilla-central/rev/4f5619be4f9c
https://hg.mozilla.org/mozilla-central/rev/cd0595cee3e0

Comment 7

[Marian-Vasile Laza]

Backed out changeset cd0595cee3e0 (Bug 1762100) for breaking msi repacks (Bug 1762172).
Backout link: https://hg.mozilla.org/integration/autoland/rev/83067e174c350e4980368ea1bb9281e066b12927

Comment 8

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

(In reply to Marian-Vasile Laza from comment #7)

Backed out changeset cd0595cee3e0 (Bug 1762100) for breaking msi repacks (Bug 1762172).
Backout link: https://hg.mozilla.org/integration/autoland/rev/83067e174c350e4980368ea1bb9281e066b12927

I'm going to leave this as RESO FIXED, and spin out the corresponding MSIX change to a separate ticket. Thanks!