Restore Zap capability potentially with double lines for hero text
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | verified |
People
(Reporter: Mardak, Assigned: emcminn)
References
(Blocks 2 open bugs)
Details
(Keywords: perf-alert)
Attachments
(2 files)
single zap example
Designs currently have a double zap under "Yous" of 100 Thank Yous. But that might have spacing/overlap issues for translations that have "Yous" not as the last word. It seems like current styling should work okay with a single zap.
|
Reporter | |
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 1•2 years ago
|
||
emcminn, with bug 1762488 patch adding zap for any Localized, this bug should just be activating zap, e.g., hero_text: { zap: true, …
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6dd62bffb5c1 Turn on Zap for hero text r=Mardak,mviar
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
|
||
Comment 5•2 years ago
|
||
== Change summary for alert #33748 (as of Wed, 06 Apr 2022 04:42:32 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 9% | welcome ContentfulSpeedIndex | macosx1015-64-shippable-qr | cold fission webrender | 1,942.00 -> 1,775.92 |
| 7% | welcome ContentfulSpeedIndex | macosx1015-64-shippable-qr | fission warm webrender | 1,822.58 -> 1,686.33 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33748
|
|
||
Updated•2 years ago
|
|
|
||
Comment 6•2 years ago
|
||
Hello Emily! Could you help figure out which of the two patches (this one or 1762290) corresponds to the performance improvement for the alert posted above ? Thank you!
|
|
Assignee | |
Comment 7•2 years ago
|
||
Hi Alex!
I've chatted with my team a bit and the only thing we can come up with is that the perf improvement may be coming from https://phabricator.services.mozilla.com/D142709; which changed the about:welcome background image to a 3kb .svg (the previous image was a 103kb .avif). These patches were all stacked and landed together, which could explain why the alert is showing up here instead. (Oddly D1422709 has a regression attached to it.) I'll make a note here if I come across anything new.
|
||
Comment 8•2 years ago
|
||
This enhancement was part of the work done on QA-1448 for which we sent a Preliminary checkpoint. Considering this I am marking it as Verified.
|
|
||
Comment 9•2 years ago
|
||
Hi Emily! Thank you for the response! Unfortunately, there was a regression associated with this revision, so I added both 1762292 and 1762290 as regressed by the logged regression defect. Once the source of the regression is identified between the two bugs, could you please remove 1765183 from the other bug's "Regressed by" field ? Thanks!
Description
•