Closed Bug 1762488 Opened 3 years ago Closed 3 years ago

Remove text configuration nesting with raw unlocalized text

Categories

(Firefox :: Messaging System, task, P1)

task

Tracking

()

RESOLVED FIXED
100 Branch
Iteration:
100.2 - March 21 - April 1
Tracking Status
firefox100 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

For example help_text has an object that can have deleteIfNotEn extra property next to the actual desired text instead of having that extra property as a subproperty because the text might be a plain string:

https://searchfox.org/mozilla-central/rev/711e1cea1cb584057c50aac0a26a3f7c969eda66/browser/components/newtab/test/unit/aboutwelcome/MultiStageAWProton.test.jsx#133-137

We can allow for the sub property by allowing raw text in an object form instead of only supporting plain string values.

This complicated bug 1752829 and was noted in bug 1762290 again.

Also allow configuring styles like zap and color. Clean up some unnecessary conditional rendering as Localized already handles that.

Blocks: 1762292
Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf7c6e049b34 Remove text configuration nesting with raw unlocalized text r=emcminn
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: