Apply UX feedback to about:welcome language switching
Categories
(Core :: Internationalization, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | verified |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
ux-feedback.png
It was a little late to be able to change the buttons to be the first prompt, but this feedback changes the buttons on the first modal to be either language choice. This minimizes the risk of invalidating the QA results by minimizing changes to the component.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Attached a patch, but the behavior needs to change where the second button will actually switch the user back to original language.
|
|
Assignee | |
Comment 3•2 years ago
|
||
This bug asserts the current behavior, which will change in a following
patch.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D142516
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b9431c3a1bf Assert the requested locales calls in about:welcome test; r=platform-i18n-reviewers,nordzilla https://hg.mozilla.org/integration/autoland/rev/e83e356f4adc Change buttons on about:welcome language prompt; r=Mardak,platform-i18n-reviewers,nordzilla,fluent-reviewers https://hg.mozilla.org/integration/autoland/rev/25106c6a3723 Ensure the AW decline button resets the app locale; r=Mardak,platform-i18n-reviewers,nordzilla
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8b9431c3a1bf
https://hg.mozilla.org/mozilla-central/rev/e83e356f4adc
https://hg.mozilla.org/mozilla-central/rev/25106c6a3723
|
||
Comment 7•2 years ago
|
||
== Change summary for alert #33777 (as of Fri, 08 Apr 2022 10:43:27 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 3% | welcome PerceptualSpeedIndex | macosx1015-64-shippable-qr | cold fission webrender | 1,394.79 -> 1,346.58 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33777
|
||
Comment 8•2 years ago
|
||
This enhancement was part of the work done on QA-1426 for which we sent a Preliminary checkpoint. Considering this I am marking it as Verified.
Description
•