Closed Bug 1762659 Opened 2 years ago Closed 2 years ago

about:welcome display names should use mozintl

Categories

(Core :: Internationalization, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
100 Branch
Iteration:
100.2 - March 21 - April 1
Tracking Status
firefox100 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Intl.DisplayNames for language do not give stand-alone version, so it makes for awkward casing in about:welcome. We should use Services.intl.getLocaleDisplayNames instead.

https://searchfox.org/mozilla-central/source/toolkit/components/mozintl/mozIntl.jsm#650

Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c7a66cae86b
Use MozIntl for stand-alone display names in LangPackMatcher.jsm; r=Mardak,nordzilla
Blocks: 1728848
Iteration: --- → 100.2 - March 21 - April 1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch

== Change summary for alert #33777 (as of Fri, 08 Apr 2022 10:43:27 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
3% welcome PerceptualSpeedIndex macosx1015-64-shippable-qr cold fission webrender 1,394.79 -> 1,346.58

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33777

Hi Greg! It seems one of these 2 bugs (this one and 1762297) has caused the improvement posted above. Could you help us identify which of the 2 bugs was the actual source for the improvement ? Thanks!

Flags: needinfo?(gtatum)

I'm not really sure which one changed it, but the order of magnitude is pretty small, and there were behavior changes in both which could result in different timings.

Flags: needinfo?(gtatum)

Thanks for the reply Greg! I'll just link the alert to this bug then.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: