Closed Bug 1762499 Opened 3 months ago Closed 2 months ago

Add PiP Video-Adapter for handling Piped Subtitles

Categories

(Toolkit :: Picture-in-Picture, enhancement)

Firefox 100
Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
101 Branch
Tracking Status
firefox-esr91 --- disabled
firefox100 --- wontfix
firefox101 --- verified
firefox102 --- verified

People

(Reporter: admin, Assigned: admin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

  1. Went to piped.kavin.rocks or piped.silkky.cloud (both are running instances of a project called Piped, which is a libre YouTube front-end)
  2. Select a video (some can be played without an account)
  3. Enable subtitles on built-in video player
  4. Click on PiP button
  5. Subtitles do not appear in PiP, only appear in built-in video player

Demo videos:
-https://piped.kavin.rocks/watch?v=cu6wpa7XXF0
-https://piped.kavin.rocks/watch?v=quKdaqlR_9w

-https://piped.silkky.cloud/watch?v=cu6wpa7XXF0
-https://piped.silkky.cloud/watch?v=quKdaqlR_9w

Actual results:

Subtitles did not properly work on piped.kavin.rocks and piped.silkky.cloud

Expected results:

Subtitles should appear in PiP

Assignee: nobody → admin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Severity: -- → N/A
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9b478864391
Add video wrapper with subtitle support for piped.kavin.rocks and piped.silkky.cloud. r=niklas,kpatenio
See Also: → 1765604
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
Blocks: 1765604
See Also: 1765604

I have verified this fix in Nightly v102.0a1 and Beta v101.0 (RC) and confirmed that the original issue is still reproducing in older branches.

Status: RESOLVED → VERIFIED
OS: Unspecified → All
Hardware: Unspecified → Desktop
You need to log in before you can comment on or make changes to this bug.