1762499 - Add PiP Video-Adapter for handling Piped Subtitles

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, enhancement)

Description

[Max]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Went to piped.kavin.rocks or piped.silkky.cloud (both are running instances of a project called Piped, which is a libre YouTube front-end)
2. Select a video (some can be played without an account)
3. Enable subtitles on built-in video player
4. Click on PiP button
5. Subtitles do not appear in PiP, only appear in built-in video player

Demo videos:
-https://piped.kavin.rocks/watch?v=cu6wpa7XXF0
-https://piped.kavin.rocks/watch?v=quKdaqlR_9w

-https://piped.silkky.cloud/watch?v=cu6wpa7XXF0
-https://piped.silkky.cloud/watch?v=quKdaqlR_9w

Actual results:

Subtitles did not properly work on piped.kavin.rocks and piped.silkky.cloud

Expected results:

Subtitles should appear in PiP

Comment 1

[Max]

Attachment: Bug 1762499 - Add video wrapper with subtitle support for piped.kavin.rocks and piped.silkky.cloud. r=#pip-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9b478864391
Add video wrapper with subtitle support for piped.kavin.rocks and piped.silkky.cloud. r=niklas,kpatenio

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e9b478864391

Comment 4

[Daniel Bodea [:danibodea]]

I have verified this fix in Nightly v102.0a1 and Beta v101.0 (RC) and confirmed that the original issue is still reproducing in older branches.