1762521 - widget/windows/JumpListBuilder.cpp fails thread safety checks

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P3)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

While looking a bug 1762484 I noticed the following issues building with warnings as errors:

 0:18.27 C:/projects/mozilla/mozilla-unified/widget/windows/JumpListBuilder.cpp(112,5): error: writing variable 'mJumpListMgr' requires holding mutex 'mMonitor' exclusively [-Werror,-Wthread-safety-analysis]
 0:18.27     mJumpListMgr = jumpListMgr;
 0:18.28     ^
 0:18.28 C:/projects/mozilla/mozilla-unified/widget/windows/JumpListBuilder.cpp(143,8): error: reading variable 'mJumpListMgr' requires holding mutex 'mMonitor' [-Werror,-Wthread-safety-analysis]
 0:18.28   if (!mJumpListMgr) return NS_ERROR_NOT_AVAILABLE;
 0:18.28        ^
 0:18.28 C:/projects/mozilla/mozilla-unified/widget/windows/JumpListBuilder.cpp(145,48): error: passing variable 'mJumpListMgr' by reference requires holding mutex 'mMonitor' [-Werror,-Wthread-safety-reference]
 0:18.28   RefPtr<ICustomDestinationList> jumpListMgr = mJumpListMgr;

I.e. there may be some further work here getting the thread safety checking happy.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1762521 - Add further locking to JumpListBuilder. r?mhowell!,jesup!

This fixes two cases where thread safety analysis complains about us not holding
the monitor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c1a5beae957
Add further locking to JumpListBuilder. r=mhowell,jesup

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/8c1a5beae957