1762484 - Enable on Windows the same warnings as on other platforms

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: ReducedThreadSafetyViolationPatch.txt

Clang's thread-safety annotations do not appear to trigger warnings on Windows when they do on other platforms. I've attached a small patch that shows changes that should create such a violation.

Changing my mozconfig to include the additional lines

export CFLAGS="-Wthread-safety -Werror=thread-safety"
export CXXFLAGS="-Wthread-safety -Werror=thread-safety"

results in the expected warnings.

I've also tried changing this line to

when=depends(c_compiler)(lambda c: c.type in ["clang", "clang-cl"] and c.version >= "8.0"),

with no mozconfig changes and I don't see any warnings. I've also tried removing the condition and just setting

check_and_add_gcc_warning("-Wthread-safety")

and that also did not produce warnings.

Comment 1

[Mike Hommey [:glandium]]

There are historic reasons we use different warning flags on Windows (hint: MSVC), but they don't apply anymore. I actually have some work in progress to enable everything that is enabled on other platforms on Windows.

Comment 2

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I'm attempting to land bug 1762839 now, and hope bug 1762490 can be landed soon(ish). Those are the only remaining blockers for me to get a local build happy.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1762484 - Allow plain values instead of functions for depends()().

This allows to remove the requirement on "--help" for dependable(),
which avoids dependable() implying the execution of when when it's
within a with only_when.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1762484 - Remove `gcc` from warning and flag function names.

This is in preparation for those functions taking care of all platforms
and compilers.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1762484 - Enable most of the same warnings on Windows as on other platforms.

This moves the manual addition of some flags from old-configure to
python configure, and disables the set of flags that still trigger a
bunch of warnings (which -Werror turns into bustage).

Comment 6

[Mike Hommey [:glandium]]

The attached patches enable everything but:

• -Wcomma
• -Wunreachable-code-return
• -Wunreachable-code
• -Wignored-qualifiers
• -Wbitfield-enum-conversion
• -Wclass-varargs
• -Wimplicit-fallthrough
• -Wsign-compare
• -Wthread-safety

I have patches for most of them, except -Wthread-safety. I will file separate bugs for each of those next week.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53c3a90bae93
Allow plain values instead of functions for depends()(). r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/d2355490a174
Remove `gcc` from warning and flag function names. r=firefox-build-system-reviewers,mhentges
https://hg.mozilla.org/integration/autoland/rev/e4effc1c1878
Enable most of the same warnings on Windows as on other platforms. r=firefox-build-system-reviewers,andi

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/53c3a90bae93
https://hg.mozilla.org/mozilla-central/rev/d2355490a174
https://hg.mozilla.org/mozilla-central/rev/e4effc1c1878

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bdcda82fcfab
adjust comm-central for "Enable on Windows the same warnings as on other platforms". rs=bustage-fix