1762801 - Content tab type reloads the page if openTab is called twice with the same URL

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

If call openTab twice with the same URL, the already open tab reloads the page. This doesn't happen on the third or subsequent calls.

This happens because when checking to see if we have an existing tab, we set the src attribute on the tab's browser element. It might've worked originally where the attribute would already have the browser's current location (and setting it to the same value did nothing), but that doesn't happen any more.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1762801 - Prevent navigation in a content tab when openTab is called again. r=john.bieling

Uses loadURI to navigate, as is used when the tab first opens, and only does it when the reference part of the URL has changed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d5f7c9562d07
Prevent navigation in a content tab when openTab is called again. r=john.bieling

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4f98a7127a58
follow-up - Fix broken tests. rs=me DONTBUILD