1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P2)

Description

[Sergey Galich [:serg]]

Currently a few items managed by LoginAutoComplete have duplicate implementations - one for the mouse click and one for the ENTER key.

Also we need the ability to asynchronously fill inputs by code running in LoginManagerParent. This will help with Firefox Relay integration, one-time passwords support, decrypting only selected passwords and with other integrations.

Comment 1

[Sergey Galich [:serg]]

Attachment: Bug 1763047 - Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e9e518bd470
Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent r=tgiles,dimi

Comment 3

[Atila Butkovits]

Backed out for causing failures at test_autocomplete_highlight_username_only_form.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/aea2c8c7f8ce357237b10996c0c19649feb72230

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=OL6PxG4jTZiDoF6fTic6JA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5e9e518bd4707f8dfa06d3ef459d9c9828542576

Failure log: https://treeherder.mozilla.org/logviewer?job_id=373771712&repo=autoland&lineNumber=9567

Comment 4

[Sergey Galich [:serg]]

Atila, I've checked the failure log, all failures are timeouts. Previous try pushes didn't have this issue and I can not reproduce locally with mach try --verify. I suspect testing infrastructure was overloaded at the moment.

What would be the right way to get it landed? Shall I try to land again?

Comment 5

[Atila Butkovits]

Let's try landing it again and see what happens.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1eb6fe5a1fa
Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent r=tgiles,dimi

Comment 7

[Cristian Tuns]

Backed out for causing mochitest failures in test_autocomplete_highlight_username_only_form.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_highlight_username_only_form.html | Test timed out. -

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2194aa4357f5
Reduce code duplication in LoginAutoComplete and introduce async filling by LoginManagerParent r=tgiles,dimi

Comment 9

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/2194aa4357f5