Closed Bug 1763142 Opened 3 years ago Closed 3 years ago

Implement transform sink/source algorithms

Categories

(Core :: DOM: Streams, task, P1)

Product:
Core
Component:
DOM: Streams
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

References

Details

Attachments

(1 file)

Bug 1763142 - Implement transform sink/source algorithms r=mgaudet,evilpie
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Blocks: 1730586
Severity: -- → S3
Priority: -- → P1
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a6a62b9c73d Implement transform sink/source algorithms r=mgaudet,emilio

Backed out for causing build bustages on TransformStream.cpp.

Push with failures

Failure log

Backout link

[task 2022-04-06T16:27:25.246Z] gmake[4]: Leaving directory '/builds/worker/workspace/obj-analyzed-browser/dom/websocket'
[task 2022-04-06T16:27:25.280Z] gmake[4]: *** Deleting file 'Unified_cpp_dom_streams0.o'
[task 2022-04-06T16:27:25.280Z] gmake[4]: Entering directory '/builds/worker/workspace/obj-analyzed-browser/dom/streams'
[task 2022-04-06T16:27:25.280Z] /builds/worker/fetches/sixgill/usr/libexec/sixgill/scripts/wrap_gcc/basecc /builds/worker/fetches/gcc/bin/g++ --sysroot /builds/worker/fetches/sysroot-x86_64-linux-gnu -std=gnu++17 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/7.5.0 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu/c++/7.5.0 -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/x86_64-linux-gnu -isystem /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include -o Unified_cpp_dom_streams0.o -c  -I/builds/worker/workspace/obj-analyzed-browser/dist/stl_wrappers -I/builds/worker/workspace/obj-analyzed-browser/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DDEBUG=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/streams -I/builds/worker/workspace/obj-analyzed-browser/dom/streams -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/workspace/obj-analyzed-browser/dist/include -I/builds/worker/workspace/obj-analyzed-browser/dist/include/nspr -I/builds/worker/workspace/obj-analyzed-browser/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-analyzed-browser/mozilla-config.h -Wno-attributes -Wno-ignored-attributes -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wno-multistatement-macros -Wno-error=class-memaccess -Wno-error=deprecated-copy -Wformat -Wformat-overflow=2 -Wno-psabi -fno-sized-deallocation -fno-aligned-new -Wno-attributes -Wno-ignored-attributes -fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -freorder-blocks -Os -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing  -MD -MP -MF .deps/Unified_cpp_dom_streams0.o.pp   Unified_cpp_dom_streams0.cpp
[task 2022-04-06T16:27:25.281Z] In file included from Unified_cpp_dom_streams0.cpp:119:
[task 2022-04-06T16:27:25.282Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In lambda function:
[task 2022-04-06T16:27:25.282Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:108:39: error: expected '{' before '->' token
[task 2022-04-06T16:27:25.283Z]   108 |           MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.284Z]       |                                       ^~
[task 2022-04-06T16:27:25.284Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In function 'already_AddRefed<mozilla::dom::Promise> mozilla::dom::TransformStreamDefaultControllerPerformTransform(JSContext*, mozilla::dom::TransformStreamDefaultController*, JS::HandleValue, mozilla::ErrorResult&)':
[task 2022-04-06T16:27:25.285Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:108:39: error: base operand of '->' has non-pointer type 'mozilla::dom::TransformStreamDefaultControllerPerformTransform(JSContext*, mozilla::dom::TransformStreamDefaultController*, JS::HandleValue, mozilla::ErrorResult&)::<lambda(JSContext*, JS::HandleValue, mozilla::ErrorResult&, const RefPtr<mozilla::dom::TransformStreamDefaultController>&)>'
[task 2022-04-06T16:27:25.285Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:108:42: error: invalid use of 'struct already_AddRefed<mozilla::dom::Promise>'
[task 2022-04-06T16:27:25.285Z]   108 |           MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.285Z]       |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-04-06T16:27:25.285Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In lambda function:
[task 2022-04-06T16:27:25.285Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:188:43: error: expected '{' before '->' token
[task 2022-04-06T16:27:25.285Z]   188 |               MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.285Z]       |                                           ^~
[task 2022-04-06T16:27:25.285Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In member function 'virtual already_AddRefed<mozilla::dom::Promise> mozilla::dom::TransformStreamUnderlyingSinkAlgorithms::WriteCallback(JSContext*, JS::Handle<JS::Value>, mozilla::dom::WritableStreamDefaultController&, mozilla::ErrorResult&)':
[task 2022-04-06T16:27:25.285Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:188:43: error: base operand of '->' has non-pointer type 'mozilla::dom::TransformStreamUnderlyingSinkAlgorithms::WriteCallback(JSContext*, JS::Handle<JS::Value>, mozilla::dom::WritableStreamDefaultController&, mozilla::ErrorResult&)::<lambda(JSContext*, JS::HandleValue, mozilla::ErrorResult&, const RefPtr<mozilla::dom::TransformStream>&, const RefPtr<mozilla::dom::TransformStreamDefaultController>&, JS::HandleValue)>'
[task 2022-04-06T16:27:25.285Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:188:46: error: invalid use of 'struct already_AddRefed<mozilla::dom::Promise>'
[task 2022-04-06T16:27:25.285Z]   188 |               MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.285Z]       |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-04-06T16:27:25.286Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In lambda function:
[task 2022-04-06T16:27:25.286Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:285:45: error: expected '{' before '->' token
[task 2022-04-06T16:27:25.286Z]   285 |                 MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.286Z]       |                                             ^~
[task 2022-04-06T16:27:25.286Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In member function 'virtual already_AddRefed<mozilla::dom::Promise> mozilla::dom::TransformStreamUnderlyingSinkAlgorithms::CloseCallback(JSContext*, mozilla::ErrorResult&)':
[task 2022-04-06T16:27:25.286Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:285:45: error: base operand of '->' has non-pointer type 'mozilla::dom::TransformStreamUnderlyingSinkAlgorithms::CloseCallback(JSContext*, mozilla::ErrorResult&)::<lambda(JSContext*, JS::HandleValue, mozilla::ErrorResult&, const RefPtr<mozilla::dom::ReadableStream>&, const RefPtr<mozilla::dom::TransformStream>&)>'
[task 2022-04-06T16:27:25.286Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:285:48: error: invalid use of 'struct already_AddRefed<mozilla::dom::Promise>'
[task 2022-04-06T16:27:25.286Z]   285 |                 MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.286Z]       |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-04-06T16:27:25.286Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In lambda function:
[task 2022-04-06T16:27:25.286Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:308:45: error: expected '{' before '->' token
[task 2022-04-06T16:27:25.287Z]   308 |                 MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.287Z]       |                                             ^~
[task 2022-04-06T16:27:25.287Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp: In member function 'virtual already_AddRefed<mozilla::dom::Promise> mozilla::dom::TransformStreamUnderlyingSinkAlgorithms::CloseCallback(JSContext*, mozilla::ErrorResult&)':
[task 2022-04-06T16:27:25.287Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:308:45: error: base operand of '->' has non-pointer type 'mozilla::dom::TransformStreamUnderlyingSinkAlgorithms::CloseCallback(JSContext*, mozilla::ErrorResult&)::<lambda(JSContext*, JS::HandleValue, mozilla::ErrorResult&, const RefPtr<mozilla::dom::ReadableStream>&, const RefPtr<mozilla::dom::TransformStream>&)>'
[task 2022-04-06T16:27:25.287Z] /builds/worker/checkouts/gecko/dom/streams/TransformStream.cpp:308:48: error: invalid use of 'struct already_AddRefed<mozilla::dom::Promise>'
[task 2022-04-06T16:27:25.287Z]   308 |                 MOZ_CAN_RUN_SCRIPT_BOUNDARY -> already_AddRefed<Promise> {
[task 2022-04-06T16:27:25.287Z]       |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~
[task 2022-04-06T16:27:25.287Z] gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:658: Unified_cpp_dom_streams0.o] Error 1
[task 2022-04-06T16:27:25.287Z] gmake[4]: Leaving directory '/builds/worker/workspace/obj-analyzed-browser/dom/streams'
[task 2022-04-06T16:27:25.288Z] gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: dom/streams/target-objects] Error 2
[task 2022-04-06T16:27:25.288Z] gmake[3]: *** Waiting for unfinished jobs....
[task 2022-04-06T16:27:25.288Z] gmake[4]: Entering directory '/builds/worker/workspace/obj-analyzed-browser/dom/serviceworkers'
Flags: needinfo?(krosylight)

Boo, I hate broken GCC interoperability.

Flags: needinfo?(krosylight)
See Also: → 1627007
Depends on: 1762537
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e64487ccd17a Implement transform sink/source algorithms r=mgaudet,emilio

https://hg.mozilla.org/mozilla-central/rev/e64487ccd17a

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: