Closed Bug 1763262 Opened 1 year ago Closed 1 year ago

Remove unused toggleMenuButtonInToolbar

Categories

(Firefox :: Bookmarks & History, task)

Product:
Firefox
Component:
Bookmarks & History
Platform:
Desktop
All
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: Gijs, Assigned: av, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

Bug 1763262 - Remove unused toggleMenuButtonInToolbar
48 bytes, text/x-phabricator-request
Details | Review

https://searchfox.org/mozilla-central/rev/911d1ebfb02cce4ff20f7ef965def04becfee710/browser/base/content/browser-places.js#2056 got used in the bookmarks tools submenu, but bug 1689366 removed that, so the code is now unused.

It would be good to doublecheck the patch in bug 1689366 to check there aren't more helper methods that can now be removed.

Blocks: 1689366
No longer blocks: 1648613

I will look into this, and see if I can locate any extra functions to remove.

Hi there,

So I have looked at the patch mentioned, and I haven't noticed any other methods that could be removed. If there is anything I missed, please let me know, and I will take a look. If I do find anything else, I will make a new comment here.

(In reply to av from comment #2)

Hi there,

So I have looked at the patch mentioned, and I haven't noticed any other methods that could be removed. If there is anything I missed, please let me know, and I will take a look. If I do find anything else, I will make a new comment here.

That's fine - are you able to submit a patch to remove toggleMenuButtonInToolbar? :-)

Flags: needinfo?(av)

Yes. I will try to get this done today.

Flags: needinfo?(av)
Assignee: nobody → av
Status: NEW → ASSIGNED
Attachment #9271187 - Attachment description: WIP: Bug 1763262 - Remove unused toggleMenuButtonInToolbar. :Gijs,kpatenio,niklas → Bug 1763262 - Remove unused toggleMenuButtonInToolbar
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c8637d6f3ea7
Remove unused toggleMenuButtonInToolbar r=Gijs

https://hg.mozilla.org/mozilla-central/rev/c8637d6f3ea7

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox101: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
You need to log in before you can comment on or make changes to this bug.