1763262 - Remove unused toggleMenuButtonInToolbar

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task)

Description

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/911d1ebfb02cce4ff20f7ef965def04becfee710/browser/base/content/browser-places.js#2056 got used in the bookmarks tools submenu, but bug 1689366 removed that, so the code is now unused.

It would be good to doublecheck the patch in bug 1689366 to check there aren't more helper methods that can now be removed.

Comment 1

[av]

I will look into this, and see if I can locate any extra functions to remove.

Comment 2

[av]

Hi there,

So I have looked at the patch mentioned, and I haven't noticed any other methods that could be removed. If there is anything I missed, please let me know, and I will take a look. If I do find anything else, I will make a new comment here.

Comment 3

[:Gijs (he/him)]

(In reply to av from comment #2)

Hi there,

So I have looked at the patch mentioned, and I haven't noticed any other methods that could be removed. If there is anything I missed, please let me know, and I will take a look. If I do find anything else, I will make a new comment here.

That's fine - are you able to submit a patch to remove toggleMenuButtonInToolbar? :-)

Comment 4

[av]

Yes. I will try to get this done today.

Comment 5

[av]

Attachment: Bug 1763262 - Remove unused toggleMenuButtonInToolbar

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8637d6f3ea7
Remove unused toggleMenuButtonInToolbar r=Gijs

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c8637d6f3ea7