176341 - configure should check for pango 1.1/1.2 when TK=GTK2 + Xft/fontconfig?

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[DJ]

I finally got Mozilla running with Xft enabled, using the 1.2b release tarball
and used the following options (along with several others) to build:

 --enable-default-toolkit=gtk2
 --disable-toolkit-gtk
 --enable-xft

When using GTK2 and Xft2/fontconfig, does Mozilla use the Pango libs as well?  I
ran into a minor problem of mozilla segfaulting. I had gtk2 and pango 1.0.x
installed prior to building Xft2/fontconfig.  Realized that pango 1.0 did not
have support for the Xft2/fontconfig libs so I installed the latest 1.1
development release. Also rebuilt GTK2 just in case.  Then I ran mozilla with
the new libs and it worked.  Previous attempts at running Mozilla reveal that I
could run with pango 1.0.x when running as root.  But that becomes a hassle when
one wants to run as normal user.

If pango is used, shouldn't it be checked at least when used with GTK2 and
Xft2/fontconfig?  Or perhaps add this to the documentation?  It sure took me a
long time to figure this little problem out.  Was this issue ever brought up
before in this setup?

Comment 1

[hacker formerly known as [e-mail]]

-> blizzard 

Comment 2

[Christopher Blizzard (:blizzard)]

Yeah, I should probably do this.  If you're using an old pango with gtk2 and you
try to use xft w/ mozilla it should probably not allow you to do so.  You get
segfaults, as you noticed.

Comment 3

[DJ]

Attachment: patch to check for pango 1.1/1.2 when needed

configure.in patch against stock 1.2b release tarball.	This checks for pango
1.1/1.2 if xft and gtk2 is enabled.  Since gtk2 depends on pango, it makes
sense to make this check before building a xft-enabled mozilla.  Comments
anyone?  Is this patch okay for checkin?

Comment 4

[Christopher Blizzard (:blizzard)]

Comment on attachment 104083 [details] [diff] [review]
patch to check for pango 1.1/1.2 when needed

r=blizzard

Comment 5

[Lawrence Walton]

added that attachment 104083 [details] [diff] [review] to my configure.in and it happily ignored it on a
CVS build.
Suggestions?
Mozilla does not build with just: 
ac_add_options --enable-default-toolkit=gtk2
ac_add_options --disable-toolkit-gtk 

Comment 6

[hacker formerly known as [e-mail]]

run autoconf

Comment 7

[Lawrence Walton]

I'm a complete autoconf newbie.
Patched configure.in to look for pango.
Deleted the configure.cache.
Ran autoconf. complained about the existing configure.in
Hacked the configure.in so that autoconf ran with no errors.
ran the "make -f client.mk"
And it still complained about not having xft.
Looks like it ignored the patch :<
Suggestions? or "Look sonny your bothering me" ? 
:>

Comment 8

[hacker formerly known as [e-mail]]

If autoconf is complaining about configure.in, then you must be running
autoconf-2.5x which we don't support (bug 104642).  You'll have to install
autoconf 2.13.

Comment 9

[Lawrence Walton]

I have  autoreconf2.13 and autoreconf2.50 both. 
They both complain; I chose to use 2.13, and such is life. :)

Comment 10

[hacker formerly known as [e-mail]]

not autoreconf. autoconf.
cd mozilla && autoconf

Comment 11

[Lawrence Walton]

Ack!! that was a cut and paste thinko
autoconf2.13
autoconf2.50
is the correct, sorry.

Comment 12

[DJ]

Attachment: better patch to check for pango 1.1/1.2

did some extra looking and poking around.  Found this is better in checking for
pango than the PKG_CHECK_MODULES macro since no extraneous variables will be
set.

Tested its patchability with trunk's configure.in and MOZILLA_1_2_BRANCH's
configure.in and both patched in fine (albeit with big offsets).  comments and
reviews anyone?

Comment 13

[Christopher Blizzard (:blizzard)]

I'm personally partial to using the macro when possible.  The extra variables
aren't going to hurt anything.

Comment 14

[Christopher Blizzard (:blizzard)]

Comment on attachment 104083 [details] [diff] [review]
patch to check for pango 1.1/1.2 when needed

Asking for review from cls.

Comment 15

[Christopher Blizzard (:blizzard)]

Comment on attachment 104083 [details] [diff] [review]
patch to check for pango 1.1/1.2 when needed

cls has given review+

Comment 16

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks!

Comment 17

[Tommi Komulainen]

I'd like to point out that this fix is artificially preventing me from building
Xft-enabled gtk2 mozilla with perfectly functional pango 1.0.5 and fontconfig.

I don't believe there's anything in mozilla requiring pango 1.1 only that
Xft2/fontconfig is properly installed.  Replacing the Xft1 library with the one
that comes with fontconfig is needed or strange segfaults will occur.