1764064 - There is no telemetry ping displayed in the "Browser Console" if the "FX_100_UPGRADE" spotlight is dismissed using the "Esc" key

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue2.gif

[Affected versions]:

• Firefox Beta 100.0b4 - Build ID: 20220410195727
• Firefox Nightly 101.0a1 - Build ID: 20220410213958

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.2
• Linux Mint 20.2 x64

[Prerequisites]:

• Have a new Fireofox profile with the following prefs in the "about:config" page:
  • "devtools.chrome.enabled" set to "true";
  • "browser.ping-centre.log" set to "true"

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Open the "Browser Console" (Ctrl + Shift + J).
3. Run the following command Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog() in the "Browser Console".
4. Focus the browser and press the "Esc" key.
5. Focus the "Browser Console" and observe the displayed pings.

[Expected result]:

• A "DISMISS" ping specific to the "FX_100_UPGRADE" spotlight is displayed.

[Actual result]:

• There is no "DISMISS" telemetry ping displayed.

[Additional Notes]:

• Attached a screen recording of the issue:

Comment 1

[Punam Dahiya [:pdahiya]]

Ideally should handle Esc as dismiss and log telemetry , it impact 1-2% user and should be ok to ride the train

Comment 2

[Meg Viar [:mviar]]

Attachment: Bug 1764064 - There is no telemetry ping displayed in the "Browser Console" if the "FX_100_UPGRADE" spotlight is dismissed using the "Esc" key

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77a186054818
There is no telemetry ping displayed in the "Browser Console" if the "FX_100_UPGRADE" spotlight is dismissed using the "Esc" key r=Mardak

Comment 4

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Telemetry will be harder to analyze with some user actions missed

Comment 5

[Meg Viar [:mviar]]

Comment on attachment 9271928 [details]
Bug 1764064 - There is no telemetry ping displayed in the "Browser Console" if the "FX_100_UPGRADE" spotlight is dismissed using the "Esc" key

Beta/Release Uplift Approval Request

• User impact if declined: Dismiss telemetry would not be captured when FX100 upgrade dialog closes.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: With telemetry logging enabled, use run Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog() from the browser console to launch the upgrade dialog. After hitting escape, a dismiss event should be logged.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only affects telemetry and should not result in a change to user experience.
• String changes made/needed: none

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/77a186054818

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (101.0a1 Build ID - 20220420094247) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20.2 x64. Now I can confirm that a "DISMISS" telemetry ping is displayed in the "Browser Console" after the "Upgrade" spotlight is dismissed using the "Esc" key.

Comment 8

[Ray Fambro]

Thank you everyone for moving so quickly on this!

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9271928 [details]
Bug 1764064 - There is no telemetry ping displayed in the "Browser Console" if the "FX_100_UPGRADE" spotlight is dismissed using the "Esc" key

Approved for 100.0b9

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5dda25ea808d

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (100.0b9 Build ID - 20220420161007) installed on Windows 10 x64, macOS 10.15.7, and Linux Mint 20.2 x64. Now I can confirm that a "DISMISS" telemetry ping is displayed in the "Browser Console" after the "Upgrade" spotlight is dismissed using the "Esc" key.