1764138 - If there is no user avatar the conv avatar is shown in the tooltip

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

When a participant that is also a buddy has no avatar, the tooltip shown when hovering their name in a conversation will show the conversation avatar instead. The tooltip should be showing the default avatar instead for the case of a non-direct conversation.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1764138 - Only show conversation icon for a user tooltip if it is a direct conversation with them. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0fa7a15e7e62
Only show conversation icon for a user tooltip if it is a direct conversation with them. r=aleca

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9271756 [details]
Bug 1764138 - Only show conversation icon for a user tooltip if it is a direct conversation with them. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): not quite sure
User impact if declined: Chat participants will have the room avatar as their avatar in tooltips when they are also contacts.
Testing completed (on c-c, etc.): Tested on c-c, no automated test!
Risk to taking this patch (and alternatives if risky): User avatars in the tooltip might not show correctly (which is exactly what this claims to fix).

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9271756 [details]
Bug 1764138 - Only show conversation icon for a user tooltip if it is a direct conversation with them. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 100.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/d52b3987dac3