1764403 - Splitting username in chat account creation doesn't work after changing protocol selection

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

The chat account creation wizard username splitting (added in bug 1699099) only works for the first protocol selected. Any change to the protocol breaks it.

STR:

• Open chat account creation wizard
• Select a protocol
• Go back from the username entry page
• Select another protocol (that has username splitting)
• Enter a username that should be split (for example a JID or Matrix user ID) into the first input and advance focus.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1764403 - Fix username splitting in chat account creation after changing protocol. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f588a7fd4977
Fix username splitting in chat account creation after changing protocol. r=mkmelin

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9271995 [details]
Bug 1764403 - Fix username splitting in chat account creation after changing protocol. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug in implementation from bug 1699108
User impact if declined: Changing protocol in chat account creation wizard leads to a less user friendly experience
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): This change is so small, I can't make out any risk that isn't just entropy.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9271995 [details]
Bug 1764403 - Fix username splitting in chat account creation after changing protocol. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 100.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/ece1fa8c65ec