1764475 - "./mach wpt <path to test> --product chrome" fails with "AttributeError: module 'tools.wpt.run' has no attribute 'virtualenv'"

Status: VERIFIED FIXED

(Testing :: web-platform-tests, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Similar to bug 1764473, might be duplicated of it, but the error is different on Linux. I got the following error when I run ./mach wpt testing/web-platform/tests/editing/run/inserttext.html --product chrome on Ubuntu.

AttributeError: module 'tools.wpt.run' has no attribute 'virtualenv'

  File "/home/toybox/mozilla/src/testing/web-platform/mach_commands.py", line 531, in run_wpt
    return run_web_platform_tests(command_context, **params)
  File "/home/toybox/mozilla/src/testing/web-platform/mach_commands.py", line 520, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "/home/toybox/mozilla/src/testing/web-platform/mach_commands_base.py", line 57, in run
    kwargs = self.setup.kwargs_wptrun(kwargs)
  File "/home/toybox/mozilla/src/testing/web-platform/mach_commands.py", line 192, in kwargs_wptrun
    venv = run.virtualenv.Virtualenv(

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

And it's no problem if I don't specify --product.

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1764475 - Fix mach wpt --product,

We were importing a module that was previously imported into wpt.run, but isn't
any longer. Directly import the relevant module instead.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's not only an issue on Linux. I can see the same on MacOS.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/097cd3dc94a7
Fix mach wpt --product, r=whimboo

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/097cd3dc94a7

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you!