1764612 - Query params in WebExtension search provider data can result in subtle differences in engine configuration

Status: RESOLVED DUPLICATE of bug 1698568

(Firefox :: Search, defect, P3)

Description

[James Teow [:jteow]]

When searchProvider.search_url contains query params, it's possible for the engine to be added in a way that's different than if the query params were provided in configuration.params.searchUrlGetParams or searchProvider.search_url_get_params.

Since the query params are not extracted from the search_url, other processes that check the EngineURL for the presence of query params will not realize that params exist since they won't be in the params array. e.g. SearchEngine._getTermsParameterName()

Comment 1

[James Teow [:jteow]]

Attachment: WIP: - Bug 1764612 - Standardize query param parsing in setUrls - r?standard8,mcheang

Comment 2

[Phabricator Automation]

Comment on attachment 9272820 [details]
WIP: - Bug 1764612 - Standardize query param parsing in setUrls - r?standard8,mcheang

Revision D143993 was moved to bug 1698568. Setting attachment 9272820 [details] to obsolete.