Closed Bug 1764669 Opened 8 months ago Closed 7 months ago

Record a dismiss/block ping for dismissed/blocked Firefox Suggest suggestions

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
3

Tracking

()

VERIFIED FIXED
101 Branch
Tracking Status
firefox101 --- verified
firefox102 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(3 files)

We want to record a dismiss/block ping for dismissed/blocked suggestions, similar to the existing impression and click pings. This will be category 3 data collection.

Note for myself: based on the data collection proposal, we need to add a new doctype for this dismissal custom ping in here.

Attached file data-request.md

Data review request for a new custom telemetry ping related to dismissed Firefox Suggest suggestions

Attachment #9272400 - Flags: data-review?(chutten)

Comment on attachment 9272400 [details]
data-request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Drew Wilcoxon is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 3, Stored Content and Communications.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+, assuming mfeldman clears his needinfo without contradicting that he did indeed approve the sensitive data collection.

(Nominally this'd be datareview- pending Legal's go ahead, but I'm familiar out-of-bounds with the review so I feel safe reversing the usual approach)

Flags: needinfo?(mfeldman)
Attachment #9272400 - Flags: data-review?(chutten) → data-review+

Confirming approval.

Flags: needinfo?(mfeldman)
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82542f401793
Record a block ping for blocked Firefox Suggest suggestions. r=nanj,daisuke
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

Hi Cosmin, I finally wrote some STR for this. Could you verify it if you have time please?

Non-best match

  1. Set the following prefs:
    browser.urlbar.quicksuggest.blockingEnabled = true
    browser.ping-centre.log = true
    
  2. Type anything that triggers a Suggest suggestion, doesn't matter if it's sponsored or not (e.g. "amazon")
  3. Verify the suggestion has a block button (thumbs down button)
  4. Click the block button
  5. Verify the suggestion disappears
  6. Open the browser console and verify two messages containing "TELEMETRY PING" are logged.
    • First message:
      • Verify "match_type":"firefox-suggest" is present
      • Verify "is_clicked":false is present
      • FYI the full message should look similar to this, but it may not match exactly except for "match_type" and "is_clicked":
        TELEMETRY PING (contextual-services): {"experiments":{},"locale":"en-US","version":"102.0a1","release_channel":"default","match_type":"firefox-suggest","advertiser":"amazon","block_id":59,"position":9,"scenario":"offline","is_clicked":false,"reporting_url":"https://imp.mt48.net/static?v=2&partner=firefox_cla&sub1=amazon&sub2=us&adv-id=74301&custom-data=59","context_id":"{d8e0a942-9470-4145-b067-7dca1268a091}"}
        
    • Second message:
      • Verify "match_type":"firefox-suggest" is present
      • FYI the full message should look similar to this (same caveats as above):
        TELEMETRY PING (contextual-services): {"experiments":{},"locale":"en-US","version":"102.0a1","release_channel":"default","match_type":"firefox-suggest","advertiser":"amazon","block_id":59,"position":9,"scenario":"offline","iab_category":"22 - Shopping","context_id":"{d8e0a942-9470-4145-b067-7dca1268a091}"}
        

Best match

You don't need to restart after completing the previous STR, but it shouldn't matter.

  1. Set the following prefs:
    browser.urlbar.bestMatch.enabled = true
    browser.urlbar.bestMatch.blockingEnabled = true
    browser.ping-centre.log = true
    
  2. Type anything that triggers a best match suggestion, doesn't matter if it's sponsored or not (e.g. "betty")
  3. Verify the suggestion has a block button (thumbs down button)
  4. Click the block button
  5. Verify the suggestion disappears
  6. Open the browser console and verify two messages containing "TELEMETRY PING" are logged.
    • First message:
      • Verify "match_type":"best-match" is present
      • Verify "is_clicked":false is present
      • FYI the full message should look similar to this, but it may not match exactly except for "match_type" and "is_clicked":
        TELEMETRY PING (contextual-services): {"experiments":{},"locale":"en-US","version":"102.0a1","release_channel":"default","match_type":"best-match","advertiser":"wikipedia","block_id":934,"position":2,"scenario":"offline","is_clicked":false,"reporting_url":"https://imp.mt48.net/static?v=2&partner=firefox_cla&sub1=wikipedia&sub2=us&adv-id=74695&custom-data=934","context_id":"{d8e0a942-9470-4145-b067-7dca1268a091}"}
        
    • Second message:
      • Verify "match_type":"best-match" is present
      • FYI the full message should look similar to this (same caveats as above):
        TELEMETRY PING (contextual-services): {"experiments":{},"locale":"en-US","version":"102.0a1","release_channel":"default","match_type":"best-match","advertiser":"wikipedia","block_id":934,"position":2,"scenario":"offline","iab_category":"5 - Education","context_id":"{d8e0a942-9470-4145-b067-7dca1268a091}"}
        
Flags: qe-verify+
Flags: needinfo?(cmuntean)
Flags: in-testsuite+

We have verified this issue on the latest Nightly 102.0a1 (Build ID: 20220508190220) and the latest Beta 101.0b4 (Build ID: 20220508185621) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

  • In order to verify this issue we have used the STR described in comment 9.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(cmuntean)
You need to log in before you can comment on or make changes to this bug.