1761059 - Implement telemetry for Suggest suggestion blocking

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

We need to implement telemetry for Suggest suggestion blocking.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1761059 - Part 1: Add telemetry scalars for Suggest suggestion blocking.

This does several things:

• Add new scalars for blocked suggestions
• Record the impression custom telemetry ping when a suggestion is blocked
• Remove the code that gets the index of the quick suggest result when the
  engagement telemetry is recorded. We can replace all that with simply
  result.rowIndex, but we need to store the result we last added in a property
  to do that, so I replaced _addedResultInLastQuery with
  _resultFromLastQuery
• Modify the urlbar engagement telemetry event code by adding the following
  selType values: "quicksuggest", "block". We can use the selType in the
  quick suggest engagement telemetry code to determine whether the block button
  or the main part of the row was clicked.

Depends on D143246

Comment 2

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=764909cc7c746bdc04a58f3f0b13e6245a437943

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1761059 - Part 2: Record an engagement telemetry event for quick suggest results.

This adds a new "engagement" telemetry event for quick suggest results. The
event's object can be the following values:

• "block": The user dismissed ("blocked") the suggestion.
• "click": The user picked the suggestion.
• "help": The user picked the suggestion's help button.
• "impression_only": The user picked some other row.

For this particular bug, we're interested in recording blocks, but there's no
reason not to generalize that idea into an engagement event like this that
records all types of interactions.

Depends on D143254

Comment 4

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=460e63fd629056dddc0a9e83afbbec2a70ec01c5
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f81e590af336cde7f4e84e1439cddae4f4289eec

Comment 5

[Drew Willcoxon :adw]

Attachment: data-request.md

Data review request for 1 new telemetry event, 5 new scalars, and a modification to 1 existing event. These are related to Firefox Suggest and the user's ability to dismiss suggestions.

Comment 6

[Chris H-C :chutten]

Comment on attachment 9271729 [details]
data-request.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Drew Willcoxon is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/519ff244fc8e
Part 1: Add telemetry scalars for Suggest suggestion blocking. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/5b2401b86818
Part 2: Record an engagement telemetry event for quick suggest results. r=daisuke

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/519ff244fc8e
https://hg.mozilla.org/mozilla-central/rev/5b2401b86818

Comment 9

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 101.0a1 build (Build ID: 20220414092955) on Windows 10 x64, macOS 11.6 and Linux Mint 20 x64. In order to test this I have set the "browser.search.region" to "US" and "browser.urlbar.quicksuggest.blockingEnabled" to true.

• The following events are correctly registered:
  "block": when the suggestion is dismissed.
  "click": when a sponsored/non-sponsored suggestion is clicked.
  "help": the help button is clicked.
  "impression_only": when a result is clicked but not sponsored/non-sponsored one.

• The following keyed scalar are registered:
  contextservices.quicksuggest#engagement#impression_only - when a result is clicked but not sponsored/non-sponsored one.
  contextservices.quicksuggest#engagement#block - when the suggestion is dismissed.
  contextservices.quicksuggest#engagement#help - the help button is clicked.
  contextservices.quicksuggest#engagement#click - when a sponsored/non-sponsored suggestion is clicked.

I have also verified these telemetries for the Best Match results. In order to do this we have changed the following prefs:
"browser.urlbar.bestMatch.enabled" to "true" and "browser.urlbar.bestMatch.blockingEnabled" to "true".