1764689 - Unnecessary use of global this in BOOKMARK_VALIDATORS.url

Status: RESOLVED FIXED

(Toolkit :: Places, task, P3)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/rev/d34f9713ae128a3138c2b70d8041a535f1049d19/toolkit/components/places/PlacesUtils.jsm#237

function simpleValidateFunc(boolValidateFn) {
  return (v, input) => {
    if (!boolValidateFn(v, input)) {
      throw new Error("Invalid value");
    }
    return v;
  };
}
...
const BOOKMARK_VALIDATORS = Object.freeze({
...
  url: v => {
    simpleValidateFunc(
      val =>
        (typeof val == "string" && val.length <= DB_URL_LENGTH_MAX) ||
        (val instanceof Ci.nsIURI && val.spec.length <= DB_URL_LENGTH_MAX) ||
        (URL.isInstance(val) && val.href.length <= DB_URL_LENGTH_MAX)
    ).call(this, v);

The this there is global this, but simpleValidateFunc returns an arrow function that doesn't use the this value on the call, but inherits from the enclosing scope.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1764689 - Remove unnnecessary global this reference in BOOKMARK_VALIDATORS.url. r?mak!

Depends on D143713

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/848dee4a3553
Remove unnnecessary global this reference in BOOKMARK_VALIDATORS.url. r=mak

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/848dee4a3553