1607331 - Reject global this usage in JSM except for special cases

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Dave Townsend [:mossop]]

We want to gather an understanding of the uses of global this in JSM files which would be unavailable when using the same code as an ES6 module. Going to add a patch here that lints for that case though for now we won't want to land it.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1607331: Add a lint check for uses of the global this in JSM files.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: updated lint rules

Modified some rules and also added rule to block globalThis property assign.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: updated lint rules

Fixed the rule to ignore this inside class properties/methods/static block

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1607331 - Part 1: Do not use global this in remote/shared/messagehandler/transports/FrameTransport.jsm. r?jdescottes

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1607331 - Part 3: Reject global this usage in JSM. r?Standard8!

Depends on D148550

Comment 6

[Tooru Fujisawa [:arai]]

remaining usage:
https://docs.google.com/spreadsheets/d/1U31iGt-2kpoEmuPSrIKG2Cd7iZjyRKlwa0eeskzsuf8/edit?usp=sharing

some are not-yet-landed patch in bug 1772101 or https://phabricator.services.mozilla.com/D148872

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fdd8b0bb660
Part 1: Do not use global this in remote/shared/messagehandler/transports/FrameTransport.jsm. r=jdescottes,webdriver-reviewers

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7fdd8b0bb660

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1607331 - Part 2: Do not use global this in browser/components/newtab/lib/DiscoveryStreamFeed.jsm. r?Mardak!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17f053b1840d
Part 2: Do not use global this in browser/components/newtab/lib/DiscoveryStreamFeed.jsm. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/0d1185dbe3e2
Part 3: Reject global this usage in JSM. r=Standard8

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/17f053b1840d
https://hg.mozilla.org/mozilla-central/rev/0d1185dbe3e2