1764789 - Discard unsaved changes - icon and close button icon can be dragged

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P5)

Description

[soapOperatest]

Attachment: Discard unsaved changes - icon and close button icon can be dragged.mov

[Affected versions]:

99.0.1 (64-bit)
101.0a1 (64-bit)

[Affected Platforms]:

macOS 10.15.7 (19H524)

[Prerequisites]:

Signed in with a valid FxA account that contains at least one login saved.

[Steps to reproduce]:

1. Access about:logins.
2. Click one of the saved logins.
3. C.lick on the "Edit" button.
4. edit the username or password.
5. Click on the "Cancel" button.
6. Grab elements on the modal.
7. drag them around.

[Expected Results]:
Elements remain in place.

[Actual Results]:
The "Discard unsaved changes" icon and close button icon are draggable.

[Notes]:
When dragging them out of the window, the icon is saved as a file on the desktop.

Comment 1

[Sergey Galich [:serg]]

:soapOperatest thanks for filing this bug!

Comment 2

[Sukhmeet[:sukh]]

Hey I would like to work on this

Comment 3

[Sergey Galich [:serg]]

:sukhmeet2002 thank you and please go ahead, once you submit the patch this bug will automatically be assigned to you.

Comment 4

[Sukhmeet[:sukh]]

Attachment: Bug 1764789 - Made icon and close button non draggable using draggable equal false r=sgalich

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31cb9db10f2d
Made icon and close button non draggable using draggable equal false r=sgalich

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/31cb9db10f2d

Comment 7

[Alice Varro [avarro], Ecosystem QA]

I have verified that this issue is no longer reproducible using Firefox Nightly 101.0a1 (Build ID - 20220419214607) on Windows 10x64, macOS 12.3.1, and Linux Mint 20.2.

• The warning icon and the close button icon from the "Discard unsaved changes" pop-up window are no longer draggable.