Colorways dialog is broken
Categories
(Firefox :: Messaging System, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox99 | --- | unaffected |
| firefox100 | --- | unaffected |
| firefox101 | --- | unaffected |
People
(Reporter: Oriol, Unassigned)
References
(Blocks 1 open bug)
Details
I launched an old Firefox (96.0.2) and got the Colorways dialog offering me to change the theme. The suggestion was the greenish Lush theme, but Firefox was still using the system theme.
I tried choosing other colors in the dialog, but the theme was still the same. It just produced this error in the browser console:
Uncaught (in promise) TypeError: null has no properties
enableTheme chrome://browser/content/upgradeDialog.js:93
I tried restarting Firefox, but I didn't get the dialog again.
The error happens in https://searchfox.org/mozilla-central/rev/ae6fa4834c00b10df8cf2ac96b7358c7a45dd3e0/browser/base/content/upgradeDialog.js#93
Bug 1754126 probably avoids the error, but I guess the dialog would still be broken.
|
||
Comment 1•4 years ago
|
||
Thanks for looking into this. We turned off the upgrade spotlight dialog in 97 with bug 1738073, and as you noticed, it's still tries to show it for 96. It seems quite unlikely we'll change 96 with release currently 99. Colorways are different from usual themes in that they expire after a date instead of with a version of Firefox, but the date aspect wasn't taken into account for the 96 upgrade dialog.
|
||
Comment 2•4 years ago
|
||
Experience is Fx96 specific and should be marked won't fix
Description
•