1765167 - Deprecate Cu.import

Status: RESOLVED FIXED

(Core :: XPConnect, task)

Description

[Tooru Fujisawa [:arai]]

Similar to bug 1765156

We have 2 ways to import JSM. ChromeUtils.import and Cu.import.

ChromeUtils.import returns exports object, but Cu.import returns global object.
The former supports lexical variables, but the latter doesn't have them, so
the latter requires variables defined on the JSM's global this property.

To achieve bug 1610653, we should replace Cu.import with ChromeUtils.import,
and then deprecate Cu.import, to avoid future confusion.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 1: Stop using Cu.import in browser/. r=Mossop!

Depends on D144093

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 2: Stop using Cu.import in devtools/. r=Mossop!

Depends on D144094

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 3: Stop using Cu.import in docshell/. r=Mossop!

Depends on D144095

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 4: Stop using Cu.import in dom/. r=Mossop!

Depends on D144096

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 5: Stop using Cu.import in js/. r=Mossop!

Depends on D144097

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 6: Stop using Cu.import in layout/. r=Mossop!

Depends on D144098

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 7: Stop using Cu.import in mobile/. r=Mossop!

Depends on D144099

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 8: Stop using Cu.import in remote/. r=Mossop!

Depends on D144100

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 9: Stop using Cu.import in testing/. r=Mossop!

Depends on D144101

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 10: Stop using Cu.import in toolkit/. r=Mossop!

Depends on D144102

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 11: Stop using Cu.import in services/. r=Mossop!

Depends on D144103

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 12: Stop using Cu.import in EventUtils.js. r=mossop!

Depends on D144104

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1765167 - Part 13: Fix eslint rule for Cu.import. r=mossop!

Depends on D144105

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1765167 - Part 14: Add deprecation warning message to Cu.import.

Depends on D144106

Comment 15

[Tooru Fujisawa [:arai]]

Some patch modifies sjs file, and ChromeUtils isn't available with the current hostutils that's from version 93.0.
will address it in bug 1765482

Comment 16

[tobias]

I'm assuming Cu.import will be removed completely in the future, so we'd like to port our autoconfig scripts. But ChromeUtils isn't available there. How should I proceed here?

Comment 17

[Tooru Fujisawa [:arai]]

(In reply to tobias from comment #16)

I'm assuming Cu.import will be removed completely in the future, so we'd like to port our autoconfig scripts. But ChromeUtils isn't available there. How should I proceed here?

I think CentralizedAdminPrefManagerInit and nsXPConnect::CreateSandbox needs to be modified to pass/receive extra option to define ChromeUtils, in the same way as Cu.Sandbox provides it

Comment 18

[Tooru Fujisawa [:arai]]

Abandoned Part 14 for adding deprecation warning.
The runtime deprecation warning should be deferred at least until after the next ESR (102), and possibly until the transition finishes for all modules.
For in-tree consumers, ESLint rule should cover well.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebebbd0619bc
Part 1: Stop using Cu.import in browser/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/3b192bbb9b92
Part 2: Stop using Cu.import in devtools/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/9c24e578ed2d
Part 3: Stop using Cu.import in docshell/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/57a5aee8b00c
Part 4: Stop using Cu.import in dom/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/0c742b244e3a
Part 5: Stop using Cu.import in js/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/ce0a760da775
Part 6: Stop using Cu.import in layout/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/c981e6933171
Part 7: Stop using Cu.import in mobile/. r=geckoview-reviewers,agi
https://hg.mozilla.org/integration/autoland/rev/280fa8df0a72
Part 8: Stop using Cu.import in remote/. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/6e8185f1cb48
Part 9: Stop using Cu.import in testing/. r=webdriver-reviewers,perftest-reviewers,whimboo,sparky,mossop
https://hg.mozilla.org/integration/autoland/rev/fcdfb914da44
Part 10: Stop using Cu.import in toolkit/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/d0eb5c083472
Part 11: Stop using Cu.import in services/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/9529d10d5b77
Part 12: Stop using Cu.import in EventUtils.js. r=mossop
https://hg.mozilla.org/integration/autoland/rev/ebcde663bae8
Part 13: Fix eslint rule for Cu.import. r=mossop

Comment 20

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ebebbd0619bc
https://hg.mozilla.org/mozilla-central/rev/3b192bbb9b92
https://hg.mozilla.org/mozilla-central/rev/9c24e578ed2d
https://hg.mozilla.org/mozilla-central/rev/57a5aee8b00c
https://hg.mozilla.org/mozilla-central/rev/0c742b244e3a
https://hg.mozilla.org/mozilla-central/rev/ce0a760da775
https://hg.mozilla.org/mozilla-central/rev/c981e6933171
https://hg.mozilla.org/mozilla-central/rev/280fa8df0a72
https://hg.mozilla.org/mozilla-central/rev/6e8185f1cb48
https://hg.mozilla.org/mozilla-central/rev/fcdfb914da44
https://hg.mozilla.org/mozilla-central/rev/d0eb5c083472
https://hg.mozilla.org/mozilla-central/rev/9529d10d5b77
https://hg.mozilla.org/mozilla-central/rev/ebcde663bae8