Open Bug 1765315 Opened 4 years ago Updated 5 days ago

Rename Storage Access API helper functions in ContentBlocking.h to be more descriptive

Categories

(Core :: Privacy: Anti-Tracking, enhancement, P3)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
enhancement

Tracking

()

People

(Reporter: bvandersloot, Unassigned)

References

(Blocks 1 open bug)

Details

No description provided.

This looks like it was completed as a side effect of bug 1765313, and can probably be resolved.

ContentBlocking.h no longer exists — the Storage Access API logic moved to StorageAccessAPIHelper when that bug landed. The only remaining matches for the filename in the tree are unrelated GeckoView javadoc links (ContentBlocking.html) in the Android changelog.

The helper names that survived the move already read the way this bug was asking for — from StorageAccessAPIHelper.h:

  • CheckBrowserSettingsDecidesStorageAccessAPI
  • CheckCallingContextDecidesStorageAccessAPI
  • CheckSameSiteCallingContextDecidesStorageAccessAPI
  • CheckExistingPermissionDecidesStorageAccessAPI
  • CheckCookiesPermittedDecidesStorageAccessAPI

Each states what it checks and what it decides, which is hard to improve on.

If there is a specific name still considered unclear it would be worth naming it here; otherwise this seems safe to close.

You need to log in before you can comment on or make changes to this bug.