1765411 - Allow configuring logo and background images using firefox-settings-attachments

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: We would like to run messaging experiments sooner with emotive images.

Similar to the fix in bug 1737770 allowing bedrock hosting of images, we can use remote settings attachments without needing to do the whole bedrock process.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1765411 - Allow configuring logo and background images using firefox-settings-attachments r?mviar

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbb23996de88
Allow configuring logo and background images using firefox-settings-attachments r=mviar

Comment 3

[Ed Lee :Mardak]

We have an alternative with bedrock, so not as urgent

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bbb23996de88

Comment 5

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Turns out we're bumping up the minimum version for the experiment to be 100 instead of 99, so this would be nice to have to be able to put images in one place instead of also depending on bedrock.

Comment 6

[Ed Lee :Mardak]

Comment on attachment 9272909 [details]
Bug 1765411 - Allow configuring logo and background images using firefox-settings-attachments r?mviar

Beta/Release Uplift Approval Request

• User impact if declined: Background images for emotive continuous onboarding messages launching for 100 show mostly empty space (attachment 9273345 [details])
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. enroll in https://experimenter.services.mozilla.com/nimbus/covered-regular-eco2204 treatment-a

2. restart Firefox (potentially again if default browser prompt showed)
3. see message with background image

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): HTML header change to allow remote settings attachments for images like bug 1737770 uplifted to 94
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Ed Lee :Mardak]

Attachment: example beta 100 message

Comment 8

[Ed Lee :Mardak]

Attachment: example nightly 101 message

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9272909 [details]
Bug 1765411 - Allow configuring logo and background images using firefox-settings-attachments r?mviar

Approved for 100.0rc1

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/852966a04dda

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

This enhancement was part of the work done on QA-1465 for which we sent a Sign off. Considering this I am marking it as Verified.