1765430 - Remove RemoteAccessibleWrap and map accessibles to their IDs in SessionAccessibility.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P1)

Description

[Eitan Isaacson [:eeejay]]

This class holds a remote accessible and forwards a subset of the Accessible interface to the inner remote accessible. This class is mostly used to provide a unified way to access accessibles given a virtual view ID and query it, or activate/scroll/focus it.

This class was written before remote and local accessibles shared a sub type. Also the doc tree traversal we currently do to find accessibles given IDs is not thread safe since it requires us to touch DOM.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1765430 - P1: Move ToBundle to SessionAccessibility. r?Jamie

Since remote accessibles won't share AccessibleWrap as a base class
anymore this can't be an instance method. Move it to
SessionAccessibility, the sole consumer.

Note: ToBundle will hopefully get removed entirely once CTW is fully adopted.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1765430 - P2: Manage Android accessible/id mappings in SessionAccessibility. r?Jamie

Depends on D144480

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1765430 - P3: Refactor Android Pivot methods. r?Jamie

This creates a clearer distinction between local pivots and remote
pivots. The former happens in the parent process and the latter happens
in the remote content process.

Depends on D144481

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1765430 - P4: Remove RemoteAccessibleWrap. r?Jamie

Depends on D144482

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30c05f76d21e
P1: Move ToBundle to SessionAccessibility. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/e8161b463a3b
P2: Manage Android accessible/id mappings in SessionAccessibility. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/47bbf5bd9315
P3: Refactor Android Pivot methods. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/72e27e3813d3
P4: Remove RemoteAccessibleWrap. r=Jamie

Comment 6

[Atila Butkovits]

Backed out for causing android bustage.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4e9d3bfc730d72855f75784a937a9ef5fa9273a1

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=PsouuVh6R3ePy0sTA--45Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=72e27e3813d30e65c86439cf91ac67bd58b5fe72

Failure log: https://treeherder.mozilla.org/logviewer?job_id=376018991&repo=autoland&lineNumber=60221

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3ccf931409c
P1: Move ToBundle to SessionAccessibility. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/1ba217a53315
P2: Manage Android accessible/id mappings in SessionAccessibility. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/f48c1dfa6db9
P3: Refactor Android Pivot methods. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/0faa4b705faa
P4: Remove RemoteAccessibleWrap. r=Jamie

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f3ccf931409c
https://hg.mozilla.org/mozilla-central/rev/1ba217a53315
https://hg.mozilla.org/mozilla-central/rev/f48c1dfa6db9
https://hg.mozilla.org/mozilla-central/rev/0faa4b705faa