1765433 - Make GetNodeInfo and Pivot methods run safely in Android UI thread

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task, P1)

Description

[Eitan Isaacson [:eeejay]]

We currently post tasks synchronously to the Gecko thread. This has been causing lockups in Fenix UI tests (and probably will in TalkBack as well).

We need to safely perform these operations in the UI thread.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1765433 - P1: Add android tests for about pages. r?Jamie

About pages run in the parent process. In the following patches we will
be performing some operations like pivot and getting node info in the
Android UI thread. We need to assure that "local" content still works
by calling into the gecko thread since we can't use the remote,
thread-safe cache.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1765433 - P2: Add AccessibilityNodeInfo population methods. r?Jamie

We cannot use GeckoBundle anymore because it cannot be constructed in
the UI thread. Instead, have a set of populate methods that take
arguments and set the correct fields in the AccessibilityNodeInfo, or
its optional info objects.

These fields can be called both in the Gecko and UI thread.

Depends on D144894

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1765433 - P3: Get bundle and do pivot in UI thread for remote accessibles. r?Jamie

Depends on D144895

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7fe140330b1
P1: Add android tests for about pages. r=Jamie,geckoview-reviewers,jonalmeida
https://hg.mozilla.org/integration/autoland/rev/29069798c8e3
P2: Add AccessibilityNodeInfo population methods. r=Jamie
https://hg.mozilla.org/integration/autoland/rev/f4fc3e2236e5
P3: Get bundle and do pivot in UI thread for remote accessibles. r=Jamie

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a7fe140330b1
https://hg.mozilla.org/mozilla-central/rev/29069798c8e3
https://hg.mozilla.org/mozilla-central/rev/f4fc3e2236e5