1765524 - MacOS menu bar has extra apple icon while PiP window is in focus

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Peter Magyari (Desktop QA)]

Attachment: Screenshot 2022-04-20 at 15.14.50.png

Affected versions

• Nightly 101.0a1

Affected platforms

• MacOS 11 / MacOS 12

Steps to reproduce

1. Open Firefox Nightly.
2. Navigate to https://www.youtube.com/watch?v=VJI88QIW7H4
3. Toggle PiP window.
4. Check MacOS menu Bar (make sure focus is on the PiP window).

Expected result

• Menu bar contains only one Apple icon.

Actual result

• Menu bar contains two Apple icons (see screenshot).

Regression range

• I believe Bug 1699936 introduced this issue.
• https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=58d678ccbab1e33834a880bcc2886533a0f0bdb0&tochange=af2c50700af73559a0a0b03e2941025ce980ff53

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:spohl, since you are the author of the regressor, bug 1699936, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

This is visually strange enough for a feature that we're promoting that it's probably worth tracking to ensure a fix lands before this goes out.

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)

[Tracking Requested - why for this release]:

This is visually strange enough for a feature that we're promoting that it's probably worth tracking to ensure a fix lands before this goes out.

For the same reason, I'd say this is enough high impact to count as S2.

Comment 4

[Ania]

Hi Peterl! The regressor patch has been backed out and landed, can you please take a look at whether this has solved the problem with the extra icon in tomorrow's Nightly build? Thank you!

Comment 5

[Peter Magyari (Desktop QA)]

I confirm that the issue is no longer present on today's Nightly 101.0a1(20220426094609)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Fixed by backout, thanks for confirming.

Comment 7

[Ania]

Fantastic, thank you everyone!

Comment 8

[Stephen A Pohl [:spohl]]

Bug 1699936 has relanded since I was no longer able to reproduce this bug here. If there is some kind of configuration that starts reproducing this issue again, please let me know and I will investigate.