176556 - gtk2 build fails with --disable-accessibility

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Tommi Komulainen]

gtk2 build tries to compile nsAccessibilityInterface.cpp even if
--disable-accessibility configuration option is used.  This causes the build to
fail because some accessibility interface headers are not found.

Comment 1

[Tommi Komulainen]

Attachment: Exclude accessibility files if disabled

This patch makes the accessibility related files to be included in the build
only if accessibility is enabled.

Comment 2

[Stephen Walker]

*** Bug 177185 has been marked as a duplicate of this bug. ***

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 104015 [details] [diff] [review]
Exclude accessibility files if disabled

r=cls on the Makefile changes though it'd be nice if one of the gtk2 owners
stepped up and ok'd the patch.

Comment 4

[Joonas]

(the dupe bug 177185 also has a patch, attachment 104414 [details] [diff] [review])

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 104015 [details] [diff] [review]
Exclude accessibility files if disabled

a=roc+moz for trunk

Comment 6

[hacker formerly known as [e-mail]]

Patch has been checked in.

Comment 7

[Yusuf Goolamabbas]

Hi, Whilst trying to compile trunk of 2002-11-08-08, I got the following errors
when I had --disable-accessibility in my configure line

I was trying to compile a xft+gtk2 build

In file included from nsAccessibilityInterface.cpp:49:
nsAccessibilityInterface.h:45:27: nsIAccessible.h: No such file or directory
make[4]: *** [nsAccessibilityInterface.o] Error 1

If I remove --disable-accessibility from the configure command line, it compiles
successfully

Comment 8

[hacker formerly known as [e-mail]]

Do we need a gtk2+xft-accessibility tinderbox?

Comment 9

[hacker formerly known as [e-mail]]

gtk2 -> blizzard

Comment 10

[Christopher Blizzard (:blizzard)]

There's already a gtk2 tinderbox, but it has accessibility turned on, since
that's important to us.

Comment 11

[Christopher Blizzard (:blizzard)]

This was checked in a while ago.