Remove obsolete .pictureInPictureToggleButton
Categories
(Toolkit :: Picture-in-Picture, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox101 | --- | fixed |
People
(Reporter: kpatenio, Assigned: aline_g)
References
Details
(Keywords: good-first-bug)
Attachments
(2 files)
We have remnants of the former pip toggle left in videocontrols.css
, and it doesn't seem to be used anymore in other parts of the codebase (searchfox). I suggest we remove them to avoid confusion with the current pip toggle we have.
Do I have to delete all class selectors .pictureInPictureToggleButton in the videocontrols.css?
(In reply to alieneguzh from comment #1)
Do I have to delete all class selectors .pictureInPictureToggleButton in the videocontrols.css?
Hi. Yes, the class selectors .pictureInPictureToggleButton need to be removed from videocontrols.css. They are not used in other files.
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Backed out 2 changesets (bug 1765639) for causing mochitest failures in browser_parsable_css
Backout link: https://hg.mozilla.org/integration/autoland/rev/5b0423ec05ed7a8d7ce9330a18ba8e55b9062a50
INFO - Console message: [JavaScript Warning: "Unknown property ‘-moz-context-properties’. Declaration dropped." {file: "jar:file:///builds/worker/workspace/build/application/firefox/browser/features/formautofill@mozilla.org.xpi!/chrome/content/formautofill.css?always-parse-css-0.9286982159528816" line: 43}]
[task 2022-04-22T22:30:25.157Z] 22:30:25 INFO - Buffered messages finished
[task 2022-04-22T22:30:25.158Z] 22:30:25 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--pip-toggle-translate-x` is not referenced -
[task 2022-04-22T22:30:25.158Z] 22:30:25 INFO - Stack trace:
[task 2022-04-22T22:30:25.158Z] 22:30:25 INFO - chrome://mochikit/content/browser-test.js:test_ok:1394
[task 2022-04-22T22:30:25.159Z] 22:30:25 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:536
Ah, sorry I completely forgot about unused custom css variables in my review for this bug.
We need to remove the following from videocontrols.css
as well:
Comment 9•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6c93c51bec92
https://hg.mozilla.org/mozilla-central/rev/819b06ff9038
Description
•