1765639 - Remove obsolete .pictureInPictureToggleButton

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, task, P3)

Description

[kpatenio]

We have remnants of the former pip toggle left in videocontrols.css, and it doesn't seem to be used anymore in other parts of the codebase (searchfox). I suggest we remove them to avoid confusion with the current pip toggle we have.

Comment 1

[:aline_g]

Do I have to delete all class selectors .pictureInPictureToggleButton in the videocontrols.css?

Comment 2

[kpatenio]

(In reply to alieneguzh from comment #1)

Do I have to delete all class selectors .pictureInPictureToggleButton in the videocontrols.css?

Hi. Yes, the class selectors .pictureInPictureToggleButton need to be removed from videocontrols.css. They are not used in other files.

Comment 3

[:aline_g]

Attachment: Bug 1765639 - removed obsolete class selectors .pictureInPictureToggleButton r=kpatenio

Comment 4

[:aline_g]

Attachment: Bug 1765639 - removed rule for .pictureInPictureToggleButton r=kpatenio

Depends on D144348

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c131b35bfd97
removed obsolete class selectors .pictureInPictureToggleButton r=kpatenio DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/da136d71ea6f
removed rule for .pictureInPictureToggleButton r=kpatenio DONTBUILD

Comment 6

[Sandor Molnar[:smolnar]]

Backed out 2 changesets (bug 1765639) for causing mochitest failures in browser_parsable_css

Backout link: https://hg.mozilla.org/integration/autoland/rev/5b0423ec05ed7a8d7ce9330a18ba8e55b9062a50

Push with failures

Failure log

INFO - Console message: [JavaScript Warning: "Unknown property ‘-moz-context-properties’.  Declaration dropped." {file: "jar:file:///builds/worker/workspace/build/application/firefox/browser/features/[e-mail]!/chrome/content/formautofill.css?always-parse-css-0.9286982159528816" line: 43}]
[task 2022-04-22T22:30:25.157Z] 22:30:25     INFO - Buffered messages finished
[task 2022-04-22T22:30:25.158Z] 22:30:25     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--pip-toggle-translate-x` is not referenced - 
[task 2022-04-22T22:30:25.158Z] 22:30:25     INFO - Stack trace:
[task 2022-04-22T22:30:25.158Z] 22:30:25     INFO - chrome://mochikit/content/browser-test.js:test_ok:1394
[task 2022-04-22T22:30:25.159Z] 22:30:25     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:536

Comment 7

[kpatenio]

Ah, sorry I completely forgot about unused custom css variables in my review for this bug.

We need to remove the following from videocontrols.css as well:

1. --pip-toggle-translate-x
2. --pip-toggle-icon-width-height

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c93c51bec92
removed obsolete class selectors .pictureInPictureToggleButton r=kpatenio
https://hg.mozilla.org/integration/autoland/rev/819b06ff9038
removed rule for .pictureInPictureToggleButton r=kpatenio

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6c93c51bec92
https://hg.mozilla.org/mozilla-central/rev/819b06ff9038