1765714 - [wayland] long menus flicker after bug 1761929

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[lilydjwg]

Attachment: flickering.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

• get a long menu, either a folder with a lot of bookmarks, or the one described in bug 1761595
• move mouse cursor over it. if it doesn't flicker or disappear, move away and move over it again.

Actual results:

The menu either keeps flickering (bookmark folder) or disappears on hovering.

Expected results:

The menu should stay still.

12:16.32 INFO: Last good revision: c554d1b188f4f4441afbee2e0e545a96034e805d
12:16.32 INFO: First bad revision: 4d56ad9b7e38714a3949a5c6dbe30119812193f8
12:16.32 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c554d1b188f4f4441afbee2e0e545a96034e805d&tochange=4d56ad9b7e38714a3949a5c6dbe30119812193f8

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Which compositor is that?
Can you run with MOZ_LOG="WidgetPopup:5" and attach the log here?
Thanks.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Does it affects all popups or do you see that with bookmarks only?

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Yes, I can reproduce it too.

Comment 5

[lilydjwg]

Attachment: fx.log.moz_log.gz

It's wlroots. Another user reports that it's reproducible with mutter.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1761929

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1765714 - Move Wayland popup bounds check to LayoutPopup(). r=stransky

It is the right place to do it, otherwise we don't have the guarantee of
it invalidating ancestor sizes or anything.

It's also what we invalidate in WaylandPopupPropagateChangesToLayout().

We otherwise do not have the guarantee of SetPopupPosition running
before or after layout, if sizes do not change. That caused the popup
size to remain big, which caused a resize loop.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5177e1f0e9e
Move Wayland popup bounds check to LayoutPopup(). r=stransky

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/b5177e1f0e9e

Comment 10

[Monica Chiorean]

I was able to reproduce the issue on Ubuntu 20.4 Wayland using build 101.0a1(20220420215300).
Verified as fixed on Ubuntu 20.4 Wayland using Beta 101.0b8 (20220517185920).

Comment 11

[goatwildernesscollective]

same issue firefox esr 102 .deb install on wayland, gnome v3.38, debian based pureos 10,, mobile phone, phosh shell 0.21.1, 720x1440, 200% scale mobile phone.

flickrs opening any menue. Flickers fast and makes menues unusable short/ or long menues, cant access settings, or add-on options, or security tracking protection menue option.