1770151 - [Wayland] Resize loop with select element bigger than the screen.

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

STR:

• Open bug 1770132's test-case.
• Hover over the select menu when open.

ER:

• Stable layout

AR: Flickering.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1770151 - Constrain size for Wayland on SetPopupPosition if needed. r=stransky

Constraining only the pref size is almost fine. We also need to
constrain the anchor size when we're sized to the popup.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9277296 [details]
Bug 1770151 - Constrain size for Wayland on SetPopupPosition if needed. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Flickering on some linux configurations.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Wayland-specific, truncates in two places instead of one, only when the popup is too big.
• String changes made/needed: none
• Is Android affected?: No

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1765714

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e7c26a560dc
Constrain size for Wayland on SetPopupPosition if needed. r=stransky

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9e7c26a560dc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9277296 [details]
Bug 1770151 - Constrain size for Wayland on SetPopupPosition if needed. r=stransky

Approved for 101.0rc1.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0c24d74593fd

Comment 8

[Virgil Sangerean]

Hello,

Unfortunately we could not find any flickering on the testcase.
We have tested the scenario on Ubuntu 20 with Wayland, on all themes and combinations (Light, Standard, Dark with and without High Contrast).

Could you please help us with more information about the configuration about the environment?

Please observe the attached video.

Comment 9

[Virgil Sangerean]

Attachment: Video trying to reproduce

Comment 10

[Darkspirit]

You need to open Firefox with Wayland backend (MOZ_ENABLE_WAYLAND=1).
The first button is a dropdown, you need to open it. The dropdown was the thing that flickered.
It doesn't flicker anymore for me.

The dropdown stretches across the whole screen in Nightly, but only across the window in Chromium. Is that expected?

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Yes.

Comment 12

[Virgil Sangerean]

Verified on Nightly 102 from 23 May 2022 and on 101.0 Firefox.