1765944 - [CTW] Transform cache does not get updated when setting a transform

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[James Teh [:Jamie]]

We have accessible/tests/browser/bounds/browser_test_simple_transform.js for this. However, even though this is broken (verified manually), this wasn't failing with CTW enabled because of a bug in testBoundsInContent; see bug 1765460 comment 4. Once my patch to fix that bug lands, these tests will fail with CTW enabled.

Comment 1

[James Teh [:Jamie]]

A bit of debugging reveals that newStyle->StyleDisplay()->HasTransformStyle() returns true, but frame->IsTransformed() returns false. I wonder if the transform happens async; i.e. after DidSetComputedStyle returns. Or perhaps it just happens later in DidSetComputedStyle; the a11y notification is right at the top. newStyle->StyleDisplay()->HasTransform(frame) returns true, so I think we can use that. I think an earlier version of the patch did that, but it was changed because we thought frame->IsTransformed() would achieve the same in this case. It appears we were wrong.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1765944: Fix transform cache updates.

The frame might not be transformed yet when MaybeQueueCacheUpdateForStyleChanges is called.
In that case, frame->IsTransformed() will return false.
However, newStyle->StyleDisplay()->HasTransform(frame) returns true, so we can use that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/161e2f9cfdfd
Fix transform cache updates. r=morgan

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/161e2f9cfdfd