1766056 - Some AV1 video is broken when not using the compositor fastpath with swgl

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This is visible here:
https://www.netflix.com/title/80057281?videoProfiles=av1-main-L30-dash-cbcs-prk

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1766056 - Fix YUV color matrix for SWGL slow and fast paths. r?jrmuizel

The brush_yuv_image slow path expected a YUV color matrix that applies scaling,
whereas we set up a matrix for SWGL that had no scaling to support the fast path.
To work around the fact that both paths have different scaling requirements, we
pass the matrix with scaling down to the fast path and undo the scaling later
when constructing SWGL's internal YUVMatrix from it. This allows both paths to
just use the same matrix and avoids the footgun.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1459526

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b91b0142c1ed
Fix YUV color matrix for SWGL slow and fast paths. r=jrmuizel

Comment 4

[Cosmin Sabou [:CosminS]]

Backed out for causing reftest failures on color_quads/720p.png.bt709.bt709.tv.yuv420p10.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b91b0142c1edecc0ac17525e79dea7e7db868c1c&selectedTaskRun=cFx0y9vQR2-YVfK-YeAEFQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=375545381&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/431286039fcf740db79492339a6d7f1463576cb7

Looks like patch from Bug 1763781 fixes these failures but that was backed out for wpt failures at canvas-display-p3-drawImage-ImageBitmap-video.html.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a422a23ba118
Fix YUV color matrix for SWGL slow and fast paths. r=jrmuizel

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a422a23ba118

Comment 8

[Jim Mathies [:jimm]]

Hey Lee, can we request beta uplift on this? Probably can't get into the RC but it would make a good dot release ride along in 100 if we feel comfortable with doing that.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

I assume we need this on ESR also?

Comment 10

[Lee Salzman [:lsalzman]]

Comment on attachment 9273495 [details]
Bug 1766056 - Fix YUV color matrix for SWGL slow and fast paths. r?jrmuizel

Beta/Release Uplift Approval Request

• User impact if declined: Visual artifacts when display HDR video (i.e. Netflix) on Software WebRender.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix is confined to some changes to the Software WebRender shader code. Only impacts HDR video.
• String changes made/needed:
• Is Android affected?: Yes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration:
• User impact if declined:
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):

Comment 11

[Jim Mathies [:jimm]]

Confirming, I was able to reproduce in release, and checking today's nightly was not able to reproduce.

Note to reliably reproduce you need to resize the browser window during the preview video.

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9273495 [details]
Bug 1766056 - Fix YUV color matrix for SWGL slow and fast paths. r?jrmuizel

Approved for 100.0rc1

Comment 13

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/1fae4668b97e

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9273495 [details]
Bug 1766056 - Fix YUV color matrix for SWGL slow and fast paths. r?jrmuizel

Approved for 91.9esr.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/666429abbdbd