1766273 - PiP subtitles support on Disney+

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, enhancement)

Description

[Ksenia Berezina [:ksenia]]

This was originally reported in https://github.com/webcompat/web-bugs/issues/101987

To reproduce, play any content from https://www.disneyplus.com/home in Picture-in-Picture mode.

Expected:
Subtitles are displayed in Picture-in-Picture window

Actual:
Subtitles are only displayed in the original video player

Comment 1

[Austen Will]

If you’re looking to grow your own marijuana, then know that it isn't as easy as you might think. You need to start with seeds, which you can buy online or from a local dispensary. https://weedseeds.garden

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1766273 - Add PiP subtitle support for Disney+. r=#pip-reviewers

Subtitle structure of disney+ seems to be the following.

<div class="dss-hls-subtitle-overlay">
  <div class="dss-subtitle-renderer-wrapper">
    <div class="dss-subtitle-renderer-cue-positioning-box">
      <div class="dss-subtitle-renderer-cue-window">
        <span class="dss-subtitle-renderer-cue">
          <span class="dss-subtitle-renderer-line">...</span>
          <span class="dss-subtitle-renderer-line">...</span>

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfb21012d7e0
Add PiP subtitle support for Disney+. r=mhowell

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/cfb21012d7e0

Comment 5

[Dianna Smith [:diannaS]]

Release Note Request
[Suggested wording]: Subtitles are now available for Disney+ in Picture-in-Picture.

Added to https://www.mozilla.org/en-US/firefox/104.0a1/releasenotes/

Comment 6

[Chris Peterson [:cpeterson]]

Setting firefox103 status flag to wontfix because I assume we don't want to uplift this PiP change to Beta 103. This change looks a little risky to uplift because it inspects the Disney web page's content, so we should let the change ride the trains with 104.

Comment 7

[Ardelean Oana, Desktop QA [:oardelean]]

I can confirm this enhancement is implemented on Firefox 104.0b7(build ID: 20220807190148) and Nightly 105.0a1(build ID: 20220807214336) on Windows 10 64-bits, Ubuntu 22.04, macOS 12.