1766364 - Fix unreachable-code warnings

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Mike Hommey [:glandium]]

browser/components/shell/nsWindowsShellService.cpp(1055,11): error: code will never be executed [-Werror,-Wunreachable-code]
  VARIANT dir;
          ^~~
layout/base/nsLayoutUtils.cpp(9615,9): error: code will never be executed [-Werror,-Wunreachable-code]
        aDocument->ShouldAvoidNativeTheme();
        ^~~~~~~~~
layout/base/nsLayoutUtils.cpp(9613,9): note: silence by adding parentheses to mark code as explicitly dead
        true ||
        ^
        /* DISABLES CODE */ ( )
widget/windows/nsPrintSettingsWin.cpp(305,9): error: fallthrough annotation in unreachable code [-Werror,-Wunreachable-code-fallthrough]
        [[fallthrough]];
        ^
widget/windows/nsPrinterWin.cpp(165,9): error: fallthrough annotation in unreachable code [-Werror,-Wunreachable-code-fallthrough]
        [[fallthrough]];
        ^

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1766364 - Fix unreachable-code warnings in Windows builds.

browser/components/shell/nsWindowsShellService.cpp(1055,11): error: code will never be executed [-Werror,-Wunreachable-code]
VARIANT dir;
^~~
layout/base/nsLayoutUtils.cpp(9615,9): error: code will never be executed [-Werror,-Wunreachable-code]
aDocument->ShouldAvoidNativeTheme();
^~~~~~~~~
layout/base/nsLayoutUtils.cpp(9613,9): note: silence by adding parentheses to mark code as explicitly dead
true ||
^
/* DISABLES CODE */ ( )
widget/windows/nsPrintSettingsWin.cpp(305,9): error: fallthrough annotation in unreachable code [-Werror,-Wunreachable-code-fallthrough]
[[fallthrough]];
^
widget/windows/nsPrinterWin.cpp(165,9): error: fallthrough annotation in unreachable code [-Werror,-Wunreachable-code-fallthrough]
[[fallthrough]];
^

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/231cb00c7161
Fix unreachable-code warnings in Windows builds. r=mhowell,emilio,rkraesig

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/231cb00c7161

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1421c33fe490
fix comm-central unreachable-code warnings in Windows builds. rs=bustage-fix