1766368 - Fix ignored-qualifiers warnings in Windows builds

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Mike Hommey [:glandium]]

browser/app/winlauncher/test/TestCrossProcessWin.cpp(151,26): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
        reinterpret_cast<const wchar_t (*)()>(::GetProcAddress(
                         ^~~~~~
widget/windows/nsWindow.h(374,8): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
  bool const DestroyCalled() { return mDestroyCalled; }
       ^~~~~~
widget/windows/nsFilePicker.h(93,5): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
    const uint32_t Length() { return mSpecList.Length(); }
    ^~~~~~
widget/windows/nsFilePicker.h(95,5): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
    const bool IsEmpty() { return (mSpecList.Length() == 0); }
    ^~~~~~

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1766368 - Fix ignored-qualifiers warnings in Windows builds.

browser/app/winlauncher/test/TestCrossProcessWin.cpp(151,26): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
reinterpret_cast<const wchar_t (*)()>(::GetProcAddress(
^~~~~~
widget/windows/nsWindow.h(374,8): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
bool const DestroyCalled() { return mDestroyCalled; }
^~~~~~
widget/windows/nsFilePicker.h(93,5): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
const uint32_t Length() { return mSpecList.Length(); }
^~~~~~
widget/windows/nsFilePicker.h(95,5): error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
const bool IsEmpty() { return (mSpecList.Length() == 0); }
^~~~~~

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fba1bc0a565
Fix ignored-qualifiers warnings in Windows builds. r=rkraesig

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9fba1bc0a565