1766388 - Add PiP Video-Adapter for supporting Hotstar Subtitles

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[Janvi Bajoria [:janvi01]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36

Steps to reproduce:

Steps to reproduce:

1. Open Hotstar.com
   2 . Select a video (example: https://www.hotstar.com/in/tv/koffee-with-karan/1525/a-peek-into-celeb-life/1000231918).
2. Enable subtitles on the built-in video player.
3. Enable PIP
   Subtitles do not appear in PiP, only appear in the built-in video player

Actual results:

Subtitles did not show up on the PIP window.

Expected results:

Subtitles should appear in the PiP window.

Comment 1

[kpatenio]

The link above might not be viewable for everyone, so linking a sample movie viewable in Canada.

I can confirm that the subtitles do not appear on the pip window when there are captions/subtitles.

Comment 2

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1766388 - Add Video-Adapter for supporting Hotstar Subtitles. r=#pip-reviewers,kpatenio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b36d6764446
Add Video-Adapter for supporting Hotstar Subtitles. r=kpatenio

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7b36d6764446

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

This enhancement has been verified on Win10-64bits, macOS 11 and Ubuntu 20.04 on Firefox 101.0b6(20220512193916), Nightly 102.0a1(20220512213051).

Comment 6

[Daniel Bodea [:danibodea]]

The video in comment 1 is no longer available. Do you know another sample that we could use to verify this implementation during regression testing (without an account)? Is there another way to find one without scrolling randomly through the content?

(I have to mention that we use Nord VPN and it no longer has the option to use India as a VPN location so a different location would be better.)

Comment 7

[kpatenio]

Hi Daniel,

Unfortunately, I'm unable to find any videos where we can test subtitles at the moment. I found out that certain trailers in the Canadian version can be viewed without an account. But, I haven't found a video that has subtitle settings - only video quality and occasionally audio settings.

Comment 8

[Janvi Bajoria [:janvi01]]

Hi Daniel,

I have found a sample which can be viewed without an account. Please look if it is accessible. Thanks!