Remove preference devtools.target-switching.server.enabled
Categories
(DevTools :: Framework, task)
Tracking
(firefox111 fixed)
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: jdescottes, Assigned: ochameau)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(1 file)
Preference was enabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1702715
I don't think we should maintain it.
|
Reporter | |
Comment 1•2 years ago
|
||
This preference is not used as is, however it has some limited value for testing as long as we still use client side targets for the TabDescriptors provided to webextension devtools panels.
tldr, setting the pref makes the TabDescriptor behave as if it was created for a webextension. We could remove the preference, but we would lose coverage for this setup (see all tests forcing the preference to false).
So I think this should be blocked on making webextension devtools panels work with server side target switching. At that point, only a few xpcshell tests will rely on this preference.
|
||
Comment 2•2 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
Assignee | |
Comment 3•1 year ago
|
||
This removes the devtools.target-switching.server.enabled preference,
which was only having an impact on tab debugging.
Toolboxes other than tabs aren't yet using "server side target switching",
which will probably happen once we enable EFT in these and
we would probably not use a preference for enabling this.
This remove all assertions in tests covering client side target switching.
And it removed a couple of tests that became irrelevant.
|
||
Updated•1 year ago
|
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8eb2c58dc415 [devtools] Consider server side target switching always enabled for tab toolboxes. r=devtools-reviewers,nchevobbe
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
Description
•