1721852 - Stop supporting client side target.

Status: ASSIGNED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Bug 1698891 will enable server side targets by default.
Once this settle and we no longer use client side target anywhere, we should remove the preference and do some cleanups.

Get rid of tests covering things that work only with client side targets, like tests against will-navigate/navigate on the target actor.
We could probably remove:

• Descriptor.getTarget methods.
• message manager connector (used by TabDescriptor.getTarget)
• some codepath in storage actor which is only for client side targets
• we probably have some other code that is only used when devtools.target-switching.server.enabled=false

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Framework' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Julian Descottes [:jdescottes]]

We can also simplify the shared-head.js navigateTo helper which can always assume a target switch is happening. See https://phabricator.services.mozilla.com/D123604#inline-682341

Comment 3

[Julian Descottes [:jdescottes]]

The situation around devtools.target-switching.server.enabled is not 100% clear to me. The preference is never set to true, except in some tests. It feels like we might be using the preference to force using client side targets for the regular toolbox, because that makes it easier? But since the preference is never set to true in practice, it's not clear that we are really testing a relevant codepath.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1721852 - [devtools] Consider server side target switching always enabled for tab toolboxes.

This removes the devtools.target-switching.server.enabled preference,
which was only having an impact on tab debugging.
Toolboxes other than tabs aren't yet using "server side target switching",
which will probably happen once we enable EFT in these and
we would probably not use a preference for enabling this.

This remove all assertions in tests covering client side target switching.
And it removed a couple of tests that became irrelevant.

Comment 5

[Phabricator Automation]

Comment on attachment 9312445 [details]
Bug 1721852 - [devtools] Consider server side target switching always enabled for tab toolboxes.

Revision D166921 was moved to bug 1766485. Setting attachment 9312445 [details] to obsolete.