176675 - Dragging links to the URL bar doesn't work as expected

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement)

Description

[Jeff Thieleke]

Dragging text or links to the URL Bar just appends the text to current URL bar
contents.  

This should be changed since Internet Explorer automatically loads links that
are dropped on its URL bar (it refuses plain text).  Also, highlighing text and
dragging it to the URL bar is a very convienient way to do a keyword search. 
This particularly true on on Windows, since it saves a copy/URL bar select/paste
operation.

Comment 1

[Jeff Thieleke]

Attachment: dragdrop handler for the URL bar

This patch adds the drop handler for the URL bar, so dragging text or links are
automatically handled as though the user entered the data into the URL bar and
submitted it.

Comment 2

[Jeff Thieleke]

Attachment: URL and Search bar ondragdrop handlers

For consistancy, and also by request
(http://www.mozillazine.org/talkback/read.php?f=15&i=967&t=965), I've added a
drop handler for the search-bar as well.

Comment 3

[Marc Boullet]

Confirming

The same occurs if you drag and drop to the search box.

Comment 4

[Yuting Kuo]

The cursor focus should also be changed to the URL/search bar so pressing Enter
will carry out the search.

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 104238 [details] [diff] [review]
URL and Search bar ondragdrop handlers

blake, can you review this patch? Thanks.

Comment 6

[Jason Bassford]

*** Bug 57228 has been marked as a duplicate of this bug. ***

Comment 7

[Ben Ruppel]

Jason, is it right to mark 57228 as a dupe of this, as this bug is specifically
for Phoenix and the other one is for mozilla?

Comment 8

[Jason Bassford]

Hmm.  Perhaps I was too quick here.  I'll reopen bug 57228 - and apologize for
the noise.

Comment 9

[Simon Paquet [:sipaq]]

Taking QA Contact

Comment 10

[Adam Roben]

Confirming bug still present on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b)
Gecko/20030804 Mozilla Firebird/0.6.1

Comment 11

[Simon Paquet [:sipaq]]

*** Bug 231430 has been marked as a duplicate of this bug. ***

Comment 12

[Blake Ross]

-> me
I just fixed the urlbar part of this but I crash when trying to make it work for
the search bar.

Comment 13

[Dorando]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7a) Gecko/20040217 Firefox/0.8.0+
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20040217 Firefox/0.8.0+

This fix does cause a crash for me if the urlbar is blank.

Comment 14

[Tim Powell]

For those that don't know, you can drag links to the Go button or a different
window to load it in Mozilla, Mozilla Firefox, and IE. With Mozilla and Firefox,
you can even drag non-hyperlinked URLs and have them load.

Comment 15

[PikeUK]

The checkin for this also created an error if the user doesn't have the URL bar
added to their toolbar (I know that the Open Location dialog is broken anyway
but that's easy to fix). Could you add an "if (gURLBar)" check in front of the
"gURLBar.addEventListener..." bit, not sure if I should file a separate bug for
this?

Comment 16

[Blake Ross]

Okay, I added the check and the search bar part of this and also added a
semi-lame  workaround for the crash.

Comment 17

[scratch]

any chance of getting a hidden pref to disable this?  i prefer the old behavior.