1767037 - Allow runtime-defined event extra keys

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Chris H-C :chutten]

The present implementation of ExtraKeys supplies the list of allowed keys via const ALLOWED_KEYS: &'static [&'static str];. This is then used in the glean-core event metric ctor to supply an owned Vec of owned Strings which the metric uses to validate incoming event records.

I think we'd have the same ergonomics but additional flexibility if we turned ALLOWED_KEYS into getAllowedKeys() on the trait. And then the runtime metrics registration use case can be satisfied by supplying a DynamicExtraKeys which is constructed with its list of allowed keys.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/2117

Comment 2

[Jan-Erik Rediger [:janerik]]

badboy merged PR #2117: "bug 1767037 - RLB: Add a new ctor to Event that takes a list of allowed event extra keys." in fee4ebe.