1767120 - [meta] Use ScaleFactors2D rather than gfxSize or similar to represent 2D scales

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Description

[Botond Ballo [:botond]]

The class ScaleFactors2D was introduced in 2015, but there's a lot of code that pre-dates it which uses size types such as gfxSize or gfx::Size to represent 2D scales.

This meta bug tracks converting such existing uses to use ScaleFactors2D.

Comment 1

[Razvan Cojocaru]

Now that all of the sub-bugs so far have been resolved, should the meta bug be closed as well, or is there additional work to appear?

Comment 2

[Botond Ballo [:botond]]

I found two final ones searching for local variables of type gfx::Size which are really scales:

https://searchfox.org/mozilla-central/rev/70504e4c6fe61c027675c792d328ee476b6b1c1f/image/RasterImage.cpp#1341
https://searchfox.org/mozilla-central/rev/70504e4c6fe61c027675c792d328ee476b6b1c1f/image/VectorImage.cpp#1227

Please feel free to file a bug for converting them.

Comment 3

[Razvan Cojocaru]

Sorry for bug 1775205, I've accidentally opened it as an enhancement (instead of task), and then had no way of changing its type by editing it - so I just closed it as invalid and created bug 1775209 instead. My mistake.

Comment 4

[Botond Ballo [:botond]]

That's all the places I can think of, so I'm going to close this.

Thank you Razvan for all your help with this!

Comment 5

[Razvan Cojocaru]

No problem, happy to help! Thanks for the prompt reviews!