1767440 - Clean up TCP rollout search param prefs

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Description

[Paul Zühlcke [:pbz]]

Bug 1766441 removed the code that set these prefs, but we still need to clean up leftover prefs from client profiles. We can do that with a migration in BrowserGlue.jsm.

Comment 1

[Paul Zühlcke [:pbz]]

Attachment: Bug 1767440 - Clean up obsolete rollout search param prefs. r=#anti-tracking!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/477de35357b8
Clean up obsolete rollout search param prefs. r=anti-tracking-reviewers,timhuang

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/477de35357b8

Comment 4

[Paul Zühlcke [:pbz]]

Comment on attachment 9274808 [details]
Bug 1767440 - Clean up obsolete rollout search param prefs. r=#anti-tracking!

Beta/Release Uplift Approval Request

• User impact if declined: Keeping these obsolete prefs in user profiles longer means increased risk for experiments that use these prefs for measurements. Clients that set these prefs may report inaccurate data to experiments.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Set the following prefs:

browser.search.param.google_channel_us = tus7
browser.search.param.google_channel_row = trow7
browser.search.param.bing_ptag = MOZZ0000000031
browser.migration.version = 126

2. Restart Firefox
   Expected: browser.search.param* prefs have been removed, browser.migration.version has been changed to 127 or higher.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We only clear very specific prefs matching in value to what we set previously. The cleanup code has automated test coverage.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9274808 [details]
Bug 1767440 - Clean up obsolete rollout search param prefs. r=#anti-tracking!

Approved for 101.0b3.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/68511cf1e574

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this task using the steps received in comment 4 and I cand confirm the following:

• The browser.search.param.google_channel_us, browser.search.param.google_channel_row, and browser.search.param.bing_ptag are removed after a browser restart.
• The browser.search.param.bing_ptag pref value is changed to 127

Verified using the latest Firefox Beta (101.0b3 Build ID - 20220505190214) and latest Firefox Nightly (102.0a1 Build ID - 20220506095052) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64.