1767618 - [about:welcome] A blank area is displayed in the top right corner of the page when the browser is horizontally resized to 25%

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: blank area.mp4

[Notes]:

• The issue is reproducible using both light and dark themes. However, the "Sign In" button is not visible only using the white theme.

[Affected versions]:

• Firefox Nightly 102.0a1
• Firefox Beta 101.0b2

[Affected Platforms]:

• Mac 10.15.7
• Windows 10 x64
• Ubuntu 20.04 x64

[Prerequisites]:

• Have the latest Firefox Nightly/Beta build installed.
• Have a new Firefox profile.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Resize the browser ~25%.
3. Observe the top right part of the "about:welcome" page.

[Expected result]:

• The page is correctly displayed and the Sign in button is visible.

[Actual result]:

• A blank area is displayed in the top right part of the page and the Sign in button is not visible if using a light theme.

[Regression]:

• The issue is not reproducible on Firefox 100 build, considering this I have used the mozregression tools to find the bug which caused this. Here are the results:
• Last good revision: b6fd2cff0114d93e9e2b69482b448441954e31d6
• First bad revision: 41bd981c36227b155896e7f0014ca634c2a90dab
• Pushlog: Link

[Additional Notes]:

• Attached is a screen recording of the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1763825

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:pdahiya, since you are the author of the regressor, bug 1763825, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1767618 - Adjust about:welcome background container minimum width

Comment 4

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]: Background UI on scroll will show blank space on browser resize to short width and height

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/625946c9e95a
Adjust about:welcome background container minimum width r=emcminn

Comment 6

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/625946c9e95a

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (102.0a1 Build ID - 20220511094252) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. I can confirm that the white area is no longer displayed in the top-right corner of the "about:welcome" page if the browser is resized to 25%.

Comment 8

[Punam Dahiya [:pdahiya]]

Comment on attachment 9275552 [details]
Bug 1767618 - Adjust about:welcome background container minimum width

Beta/Release Uplift Approval Request

• User impact if declined: User will see a blank area on about:welcome when browser is resized to smaller widths
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: https://bugzilla.mozilla.org/show_bug.cgi?id=1767618#c0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch with CSS fix
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9275552 [details]
Bug 1767618 - Adjust about:welcome background container minimum width

Approved for 101.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/78d6b2ccd950

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (101.0b6 Build ID - 20220512193916) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. I can confirm that the white area is no longer displayed in the top-right corner of the "about:welcome" page if the browser is resized to 25%.